fix(auth): clear local session on signout failures#2503
Closed
pjpjq wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2501.
signOut()previously returned immediately when the remote logout request produced a retryable/network auth error. Forglobalandlocalsign-out scopes that meant the persisted browser/device session remained in storage, so an offline sign-out could reject while leaving the user locally authenticated.This PR keeps the existing
otherssemantics, but ensuresglobalandlocalscopes always clear the current local session before returning the remote logout error.Testing
pnpm install --frozen-lockfilepnpm --dir packages/core/auth-js exec jest --config jest.config.js test/GoTrueClient.signOut.test.ts --runInBand --silent=falsepnpm nx build auth-jspnpm prettier --check packages/core/auth-js/src/GoTrueClient.ts packages/core/auth-js/test/GoTrueClient.signOut.test.tspnpm exec eslint packages/core/auth-js/test/GoTrueClient.signOut.test.tsgit diff --checkNote:
pnpm exec eslint packages/core/auth-js/src/GoTrueClient.ts ...is currently blocked by pre-existing lint errors inGoTrueClient.ts(unused variables / no-empty-object-type outside this diff), so I linted the new test file directly and relied onpnpm nx build auth-jsfor the changed source file.