fix(auth): notify after exchangeCodeForSession lock for SSR#2038
Open
samarth212 wants to merge 5 commits intosupabase:masterfrom
Open
fix(auth): notify after exchangeCodeForSession lock for SSR#2038samarth212 wants to merge 5 commits intosupabase:masterfrom
samarth212 wants to merge 5 commits intosupabase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(auth): notify after exchangeCodeForSession lock for SSR
🔍 Description
Fix SSR OAuth callback cookie persistence by moving
SIGNED_INnotification outside the auth lock inexchangeCodeForSessionand adding regression tests.What changed?
SIGNED_INafterexchangeCodeForSessionreleases the lock, avoiding serverless/SSR timing issues.setTimeoutnotification for PKCE exchange.Why was this change needed?
SSR/serverless callbacks (e.g. Next.js route handlers using
@supabase/ssr) rely onSIGNED_INto persist cookies before the response returns. Deferring notification caused missing cookies in OAuth flows.Closes #2037
📸 Screenshots/Examples
N/A
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting📝 Additional notes
Tests run:
npx nx test:auth auth-js