fix(auth): defer subscriber notification in exchangeCodeForSession to prevent deadlock#2014
Merged
mandarini merged 1 commit intosupabase:masterfrom Jan 12, 2026
Merged
Conversation
… prevent deadlock
Contributor
Author
mandarini
approved these changes
Jan 12, 2026
6 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defers
_notifyAllSubscriberscall in_exchangeCodeForSessionusingsetTimeoutto prevent deadlock on iOS/Capacitor PKCE OAuth flow.Problem
On iOS/Capacitor with PKCE flow,
exchangeCodeForSession()would hang indefinitely when a subscriber callback (inonAuthStateChange) tried to callgetSession()or make authenticated requests.The deadlock occurred because:
exchangeCodeForSession()acquires a lock via_acquireLock()await _notifyAllSubscribers()which awaits all subscriber callbacksgetSession(), it tries to acquire the same lockgetSession()call to wait for the current operationgetSession()which waits for lock which waits for subscriberSolution
Defer
_notifyAllSubscribersusingsetTimeout(..., 0)so it runs after the lock is released.This matches the existing pattern used here: https://github.com/supabase/supabase-js/blob/master/packages/core/auth-js/src/GoTrueClient.ts#L521
Related
Closes #1566
Thanks @simplysparsh