Skip to content

chore: remove steal fallback from debuggableNavigatorLock#43172

Merged
mandarini merged 2 commits intomasterfrom
chore/remove-navigator-lock-steal-from-platform
Feb 25, 2026
Merged

chore: remove steal fallback from debuggableNavigatorLock#43172
mandarini merged 2 commits intomasterfrom
chore/remove-navigator-lock-steal-from-platform

Conversation

@mandarini
Copy link
Contributor

@mandarini mandarini commented Feb 25, 2026

The SDK now handles orphaned lock recovery via steal internally (supabase-js#2106). Keep the BroadcastChannel observability wrapper for Sentry signals. The steal-based orphaned lock recovery in debuggableNavigatorLock (packages/common/gotrue.ts) (introduced in #39868) is now redundant, supabase-js#2106 handles this natively in the SDK.

Removes the navigator.locks.request({ steal: true }) block while keeping the BroadcastChannel wrapper that sends lock-holder stack traces to Sentry.

Related: supabase/supabase-js#2106, supabase/supabase-js#2125

@vercel
Copy link

vercel bot commented Feb 25, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Ready Ready Preview, Comment Feb 25, 2026 4:16pm
docs Ready Ready Preview, Comment, Open in v0 Feb 25, 2026 4:16pm
learn Ready Ready Preview, Comment Feb 25, 2026 4:16pm
studio-self-hosted Ready Ready Preview, Comment Feb 25, 2026 4:16pm
studio-staging Ready Ready Preview, Comment Feb 25, 2026 4:16pm
ui-library Ready Ready Preview, Comment Feb 25, 2026 4:16pm
zone-www-dot-com Ready Ready Preview, Comment, Open in v0 Feb 25, 2026 4:16pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Feb 25, 2026 4:16pm
studio Ignored Ignored Feb 25, 2026 4:16pm

Request Review

@supabase
Copy link

supabase bot commented Feb 25, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mandarini mandarini self-assigned this Feb 25, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between df8729a and e573f2e.

📒 Files selected for processing (1)
  • packages/common/gotrue.ts
📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved lock acquisition timeout handling to prevent forced lock stealing, allowing the system to rely on standard lock mechanisms without automatic intervention.

Walkthrough

The pull request modifies the Navigator Locks timeout handling in packages/common/gotrue.ts. Previously, when a lock acquisition attempt exceeded a 10-second timeout, the code would automatically invoke navigator.locks.request with the steal: true flag to forcibly acquire the lock, then immediately release it and capture any errors. This fallback mechanism has been entirely removed. The updated code now logs the timeout event but does not attempt to steal or manipulate the lock, leaving lock acquisition solely to the original navigator lock mechanism and its callback.

Comment @coderabbitai help to get the list of available commands and usage tips.

@everettbu everettbu mentioned this pull request Feb 25, 2026
Closed
@mandarini mandarini enabled auto-merge (squash) February 25, 2026 16:10
@mandarini mandarini merged commit 996104a into master Feb 25, 2026
29 checks passed
@mandarini mandarini deleted the chore/remove-navigator-lock-steal-from-platform branch February 25, 2026 16:19
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026 •
edited
Loading

Braintrust eval report

Assistant (master-1772036677)

Score Average Improvements Regressions
Completeness 100% (+6pp) 2 🟢 -
Conciseness 1.4% (+0pp) 1 🟢 1 🔴
Goal Completion 95.8% (+3pp) 2 🟢 -
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+6pp) 1 🟢 -
Tool Usage 100% (+0pp) - -
Correctness 100% (+8pp) 1 🟢 -
Docs Faithfulness 58.8% (-5pp) - 2 🔴
URL Validity 90.9% (-4pp) - 1 🔴
Time_to_first_token 0.31tok (+0.02tok) 4 🟢 8 🔴
Llm_calls 8.22 (-0.11) 4 🟢 7 🔴
Tool_calls 2.89 (-0.19) 3 🟢 6 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 44536.58tok (-12967.75tok) 7 🟢 5 🔴
Prompt_cached_tokens 23288.89tok (-2865.78tok) 3 🟢 8 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 2646.94tok (-155.22tok) 5 🟢 7 🔴
Completion_reasoning_tokens 1930.67tok (-97.78tok) 6 🟢 6 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 47183.53tok (-13122.97tok) 7 🟢 5 🔴
Estimated_cost 0.01$ (0$) 6 🟢 5 🔴
Duration 46.76s (-2.65s) 6 🟢 6 🔴
Llm_duration 91.73s (-4.88s) 6 🟢 6 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivasilov ivasilov ivasilov approved these changes

@fadymak fadymak fadymak approved these changes

Assignees

@mandarini mandarini

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mandarini @ivasilov @fadymak