Skip to content

Conversation

@thinkjrs
Copy link
Contributor

@thinkjrs thinkjrs commented Nov 8, 2023

Update doc_hash to hash since running this as-is provided an AttributeError.

Here's what the Python built-in vars(documents[0]) gives me (truncated):

{'id_': 'd94b1287-b3ef-4aba-ac6b-7a4e353b0327',
 'embedding': None,
 'metadata': {},
 'excluded_embed_metadata_keys': [],
 'excluded_llm_metadata_keys': [],
 'relationships': {},
 'hash': '4c702b4df575421e1d1af4b1fd50511b226e0c9863dbfffeccb8b689b8448f35',...}

What kind of change does this PR introduce?

Docs example update/bugfix.

What is the current behavior?

Running the Llamaindex example spits out an AttributeError in cell 4 for the non-extant doc_hash attribute, which has been changed to hash, as you can see in the above output from vars which I ran on the Document object returned in the documents array within the notebook.

What is the new behavior?

It is the expected output as before: the string hash is printed.

Additional context

This merge is not consequential to the library's functionality in any way but allows the example notebook to execute without error.

Update `doc_hash` to `hash` since running this as-is provided an `AttributeError`. 

Here's what the Python build-in `vars` gives me (truncated):

```python
{'id_': 'd94b1287-b3ef-4aba-ac6b-7a4e353b0327',
 'embedding': None,
 'metadata': {},
 'excluded_embed_metadata_keys': [],
 'excluded_llm_metadata_keys': [],
 'relationships': {},
 'hash': '4c702b4df575421e1d1af4b1fd50511b226e0c9863dbfffeccb8b689b8448f35',...}
```
@vercel
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 6:00pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 6:00pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 6:00pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 6:00pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 6:00pm
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 6:00pm

@vercel
Copy link

vercel bot commented Nov 8, 2023

@thinkjrs is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@gregnr gregnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thinkjrs!

Just tried this out again and noticed the SimpleWebPageReader import has also changed on the llama_index side - updated to fix that as well.

@gregnr gregnr merged commit 5886d06 into supabase:master Nov 17, 2023
joshenlim pushed a commit that referenced this pull request Nov 19, 2023
* Update llamaindex.ipynb doc_hash to hash

Update `doc_hash` to `hash` since running this as-is provided an `AttributeError`. 

Here's what the Python build-in `vars` gives me (truncated):

```python
{'id_': 'd94b1287-b3ef-4aba-ac6b-7a4e353b0327',
 'embedding': None,
 'metadata': {},
 'excluded_embed_metadata_keys': [],
 'excluded_llm_metadata_keys': [],
 'relationships': {},
 'hash': '4c702b4df575421e1d1af4b1fd50511b226e0c9863dbfffeccb8b689b8448f35',...}
```

* fix: SimpleWebPageReader & StorageContext imports

* chore: revert python version change

---------

Co-authored-by: Greg Richardson <[email protected]>
joshenlim added a commit that referenced this pull request Nov 21, 2023
* feat(sql-editor): cli commands to import snippet as migration/seed

* fix(sql-editor): reword to download snippet

* chore(sql-editor): update wording

* Move to tabed ui, move download button to context menu

* Inline

* feat: add react native auth blog and quickstart. (#19006)

* feat: add react native auth blog and quickstart.

* Grammarly check

* Minor edits.

* Added og image.

* chore: add password sign in and gif.

---------

Co-authored-by: Ramiro Nuñez Dosio <[email protected]>

* fix: duplicate eslint dependency (#19028)

* Update sveltekit.mdx (#18998)

Extended authorization section of docs to mention use of Sveltekit sequence helper function for protecting routes alongside defining Supabase session. Also provided new code.

Co-authored-by: Charis <[email protected]>

* fix: add hello world example to edge functions quickstart (#19030)

* Fix project card status not showing (#19034)

* Fix project card status not showing

* Fix tooltip project card styling

* chore: update cli reference doc (#18934)

* Add docs for updating the image versions (#18160)

see #17930

* chore: fix casing of "encryption at rest" (#19032)

* chore: update self-hosted image versions (#18935)

chore: update image versions for docker/docker-compose.yml

* (docs) Update arg name that resulted from adapters release (#19024)

update arg name that resulted from adapters release

* docs: Fix an example (@supabase/ssr package) for Next.js API Route (#19009)

Update creating-a-client.mdx

replace `appendHeader` with `setHeader` for the Next.js API route example.

* chore: cleanup studio dependencies (#19040)

* Fix code text color (#19042)

* make dark: selector work again

* fix reference docs code color

* feat: remove note about tus rollout (#19007)

it has been rolled out to all projects

* docs: update language in database-size.mdx code block (#19033)

Co-authored-by: Kevin Grüneberg <[email protected]>
Co-authored-by: Copple <[email protected]>

* Docs: Adds a page for enums (#18590)

* Adds a page for enums

* Adds some details on deleting values

* Update apps/docs/pages/guides/database/postgres/enums.mdx

Co-authored-by: Kevin Grüneberg <[email protected]>

* Update apps/docs/pages/guides/database/postgres/enums.mdx

Co-authored-by: Kevin Grüneberg <[email protected]>

* Update apps/docs/pages/guides/database/postgres/enums.mdx

Co-authored-by: Kevin Grüneberg <[email protected]>

* Update apps/docs/pages/guides/database/postgres/enums.mdx

Co-authored-by: Charis <[email protected]>

* removes dangerous operation

---------

Co-authored-by: Kevin Grüneberg <[email protected]>
Co-authored-by: Charis <[email protected]>

* Update hugging-face.mdx: fix example curl request (#17667)

The example request did not match the example edge function because there is used prompt and in the curl script was used query

* docs: fix syntax error in create role command (#17755)

* Update auth-sso-saml.mdx (#17856)

* docs: Update auth-google.mdx (#18119)

* fix: Bump up Realtime to 2.25.35 (#19048)

* Update llamaindex.ipynb doc_hash to hash (#18838)

* Update llamaindex.ipynb doc_hash to hash

Update `doc_hash` to `hash` since running this as-is provided an `AttributeError`. 

Here's what the Python build-in `vars` gives me (truncated):

```python
{'id_': 'd94b1287-b3ef-4aba-ac6b-7a4e353b0327',
 'embedding': None,
 'metadata': {},
 'excluded_embed_metadata_keys': [],
 'excluded_llm_metadata_keys': [],
 'relationships': {},
 'hash': '4c702b4df575421e1d1af4b1fd50511b226e0c9863dbfffeccb8b689b8448f35',...}
```

* fix: SimpleWebPageReader & StorageContext imports

* chore: revert python version change

---------

Co-authored-by: Greg Richardson <[email protected]>

* fix: add reference docs back to search index (#19054)

Reference docs weren't being indexed properly because the specs weren't
getting checked out at build time.

* docs: add RN videos and discoverability improvements. (#18633)

* docs: add RN videos and discoverability improvements.

* Apply suggestions from code review

Co-authored-by: Copple <[email protected]>

* chore: run prettier.

---------

Co-authored-by: Copple <[email protected]>

* docs: add getting started guide for Swift (#19044)

* docs: getting started guide for Swift

* Apply suggestions from code review

Co-authored-by: Charis <[email protected]>

* Add new tutorial to menu

* Add correct image for tutorial

* style: format with-swift tutorial

* docs: add example to the repository

---------

Co-authored-by: Charis <[email protected]>
Co-authored-by: Thor 雷神 Schaeff <[email protected]>

* docs: Update mentions of `foreign table` to `referenced table` (#18656)

* replace foreignTable parameter with referencedTable parameter

* remove redirects

* rename any mentions of foreign table to referenced table

* fix one mention of foreign table

* update some links

* guide: add pgroonga videos to pgroonga guide (#19073)

add pgroonga videos to pgroonga guide

* docs(swift): rename `authStateChanges` and remove `File` from upload method (#19067)

docs: fix authStateChanges and upload documentation

* Small style fixes

* Style

* Update

* Update

* Update UI components positioning for DownloadSnippetModal

---------

Co-authored-by: Terry Sutton <[email protected]>
Co-authored-by: Thor 雷神 Schaeff <[email protected]>
Co-authored-by: Ramiro Nuñez Dosio <[email protected]>
Co-authored-by: Kevin Grüneberg <[email protected]>
Co-authored-by: uncapped1599 <[email protected]>
Co-authored-by: Charis <[email protected]>
Co-authored-by: Lakshan Perera <[email protected]>
Co-authored-by: Joshen Lim <[email protected]>
Co-authored-by: Copple <[email protected]>
Co-authored-by: Div Arora <[email protected]>
Co-authored-by: Oliver Rice <[email protected]>
Co-authored-by: Taishi <[email protected]>
Co-authored-by: Francesco Sansalvadore <[email protected]>
Co-authored-by: Inian <[email protected]>
Co-authored-by: Joseph Yu <[email protected]>
Co-authored-by: Maidi <[email protected]>
Co-authored-by: Shinya Fujino <[email protected]>
Co-authored-by: Andrei Soroker <[email protected]>
Co-authored-by: Isaac Abotsi <[email protected]>
Co-authored-by: Filipe Cabaço <[email protected]>
Co-authored-by: Jason R. Stevens, CFA <[email protected]>
Co-authored-by: Guilherme Souza <[email protected]>
Co-authored-by: Tyler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants