Skip to content

Comments

chore: Docusaurus with webpack 5#1256

Merged
kiwicopple merged 10 commits intosupabase:masterfrom
slorber:master
Sep 9, 2021
Merged

chore: Docusaurus with webpack 5#1256
kiwicopple merged 10 commits intosupabase:masterfrom
slorber:master

Conversation

@slorber
Copy link
Contributor

@slorber slorber commented Apr 23, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site, detect potential problems, and perf improvements.

See also facebook/docusaurus#4089

@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nextjs-todo-list – ./examples/nextjs-todo-list

🔍 Inspect: https://vercel.com/supabase/nextjs-todo-list/JCwLoaFp6FPtB5mUBvjRLAQThNoF
✅ Preview: Canceled

[Deployment for b537714 canceled]

www – ./www

🔍 Inspect: https://vercel.com/supabase/www/dXEKAPcR5noaYWpFZP7xmJyVFXGy
✅ Preview: https://www-git-fork-slorber-master-supabase.vercel.app

[Deployment for 10d0c48 canceled]

main – ./

🔍 Inspect: https://vercel.com/supabase/main/3B16yvj6rCW4GoW1RgihqoT1fcxR
✅ Preview: https://main-git-fork-slorber-master-supabase.vercel.app

docs – ./web

🔍 Inspect: https://vercel.com/supabase/docs/3u3FSHotVJBVt7qEQxgDrsZ7NS7c
✅ Preview: https://docs-git-fork-slorber-master-supabase.vercel.app

about – ./about

🔍 Inspect: https://vercel.com/supabase/about/EGxi3oCKg85UXzMEBbPxepzuPaEz
✅ Preview: https://about-git-fork-slorber-master-supabase.vercel.app

organizationName: 'supabase', // Usually your GitHub org/user name.
projectName: 'supabase', // Usually your repo name.
themeConfig: {
forceDarkMode: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these do not exist

@slorber slorber marked this pull request as draft April 23, 2021 15:04
@kiwicopple
Copy link
Member

Great, thanks @slorber - note that you can use this URL to get the preview (we have redirects on the monorepo):

https://docs-git-fork-slorber-master-supabase.vercel.app/docs

There are a few css/formatting issue I can see, probably missing CSS classes in the updated docusaurus theme

@slorber
Copy link
Contributor Author

slorber commented Apr 26, 2021

hi @kiwicopple

I've opened a similar PR to like 20 Docusaurus sites to validate the Webpack 5 support works decently.
Unfortunately, I won't be able to fix the CSS of those 20 sites 😅
Once I release the next Docusaurus version with Webpack 5, if you feel this PR can't be merged as is, don't hesitate to commit to my PR (you have write access to my work), complete it or re-open it.

Sometimes upgrading Docusaurus to the latest version breaks some CSS, as we have a quite "implicit API surface" due to any user being able to override the default theme and provide custom CSS. We'll try to improve so that it does not happen too frequently in the future.

@kiwicopple
Copy link
Member

I won't be able to fix the CSS of those 20 sites

Understood, thanks for upgrading us! We'll make it look great

@slorber
Copy link
Contributor Author

slorber commented May 1, 2021

ready for review, as alpha 75 has been released with webpack 5

I'll let you fix the last CSS details of this PR, or close it and open a new PR if you want, just wanted t let you know the webpack 5 support is ready

@MildTomato
Copy link
Member

MildTomato commented Sep 9, 2021

fixing the CSS on this now - sorry that took (checks watch..) 4 months 😬

@kiwicopple kiwicopple merged commit 404b46e into supabase:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants