Skip to content

Merge:'fix/shopsell'| 售卖流程的优化#236

Merged
sunyink merged 2 commits intomainfrom
fix/shopsell
Mar 25, 2026
Merged

Merge:'fix/shopsell'| 售卖流程的优化#236
sunyink merged 2 commits intomainfrom
fix/shopsell

Conversation

@sunyink
Copy link
Copy Markdown
Owner

@sunyink sunyink commented Mar 25, 2026 •
edited by coderabbitai bot
Loading

Summary by Sourcery

更新与商店售卖流程相关的套利管道配置。

Original summary in English

Summary by Sourcery

Update the Arbitrage pipeline configuration related to the shop selling flow.

Summary by CodeRabbit

发布说明

  • Bug 修复

    • 优化了商品出售流程中物品列表的排序验证机制，确保排序模式准确无误。

  • 改进

    • 增强了排序类型检测与自动纠正功能，提升用户操作的可靠性。
    • 改进了界面提示文案，为用户提供更清晰的操作指引。

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026 •
edited
Loading

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

概述

在套利出售流程中，新增物品列表排序模式的校验与纠正逻辑。通过引入排序校验节点检验价格排序模式是否正确，在不满足条件时触发排序修正链，使流程能够自动检测并修正排序配置。

变更

流程层级/文件 变更摘要
商店列表滑动节点
Arbitrage.json·Arbitrage_Select_Swip		 新增 focus 参数为 "Arb.商店列表滑动""，用于标识滑动操作定位文案。
出售商品选择后处理
Arbitrage.json·Arbitrage_Sell_PackShopSwich_Clr		 修改 next 路由：原单一路径改为先进入排序校验节点 Arbitrage_ItemList_Sorting_AllRight，再根据校验结果分支至排序纠正链 Arbitrage_ItemList_Sorting_Type_Not。
物品列表排序校验链
Arbitrage.json·Arbitrage_ItemList_Sorting_AllRight、Arbitrage_ItemList_Sorting_Type_Ent、Arbitrage_ItemList_Sorting_Reverse		 新增7个排序校验与纠正节点，通过模板匹配与颜色验证检查排序类型和升降序方向的正确性，实现完整的排序模式校验逻辑。
物品列表滑动节点
Arbitrage.json·Arbitrage_ItemList_Swip		 添加 enabled: false 禁用滑动功能；更新 focus 参数为 `"Arb.sell.物品列表滑动"``；更新节点文档说明依赖排序校验后不使用滑动。

序列图

sequenceDiagram
    participant 出售流程 as 出售流程
    participant 商店切换 as Arbitrage_Sell_PackShopSwich_Clr
    participant 排序校验 as Arbitrage_ItemList_Sorting_AllRight
    participant 类型检验 as Arbitrage_ItemList_Sorting_Type_Ent
    participant 升降检验 as Arbitrage_ItemList_Sorting_Reverse
    participant 排序纠正 as Arbitrage_ItemList_Sorting_Type_Not
    participant 后续流程 as 物品列表遍历

    出售流程->>商店切换: 执行商店清除
    商店切换->>排序校验: 触发排序校验流程
    排序校验->>类型检验: 检查价格/类型图标模板
    排序校验->>升降检验: 检查升降序方向与颜色
    
    alt 排序模式正确
        类型检验-->>排序校验: 通过
        升降检验-->>排序校验: 通过
        排序校验->>后续流程: next 跳转
    else 排序模式错误
        类型检验-->>排序校验: 不匹配
        排序校验->>排序纠正: 进入纠正链
        排序纠正->>排序纠正: 点击切换排序模式
        排序纠正->>排序纠正: OCR验证溢价率模式
        排序纠正->>排序纠正: 颜色校验确认
        排序纠正->>后续流程: 纠正完成后继续
    end
Loading

代码审核工作量评估

🎯 3 (中等) | ⏱️ ~20 分钟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR标题「售卖流程的优化」准确概括了主要变更内容——优化Arbitrage售卖流程中的物品列表排序校验逻辑。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/shopsell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 25, 2026 •
edited
Loading

评审者指南（在小型 PR 上折叠）

评审者指南

通过更新 Arbitrage.json 资源定义，优化用于商店出售流程的套利流水线配置。

文件级变更

变更 详情 文件
调整商店出售流程的套利流水线配置。
  • 修改出售流程中使用的套利流水线 JSON 的参数或结构
  • 更新配置值以优化或修正出售行为
  • 可能会添加、移除或重新排序与套利处理相关的流水线步骤
 assets/resource/pipeline/Arbitrage.json
提示与命令

与 Sourcery 交互

  • 触发新的评审： 在拉取请求中评论 @sourcery-ai review。
  • 继续讨论： 直接回复 Sourcery 的评审评论。
  • 从评审评论生成 GitHub Issue： 在评审评论下回复，请求 Sourcery 从该评论创建一个 Issue。你也可以在评审评论下回复 @sourcery-ai issue 来从该评论创建 Issue。
  • 生成拉取请求标题： 在拉取请求标题的任意位置写上 @sourcery-ai，即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title 来（重新）生成标题。
  • 生成拉取请求摘要： 在拉取请求正文的任意位置写上 @sourcery-ai summary，即可在你想要的位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary 来（重新）生成摘要。
  • 生成评审者指南： 在拉取请求中评论 @sourcery-ai guide，即可随时（重新）生成评审者指南。
  • 解决所有 Sourcery 评论： 在拉取请求中评论 @sourcery-ai resolve，即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不想再看到它们，这将非常有用。
  • 忽略所有 Sourcery 评审： 在拉取请求中评论 @sourcery-ai dismiss，即可忽略所有现有的 Sourcery 评审。若你想从一次全新的评审开始，这尤其有用——别忘了再评论 @sourcery-ai review 来触发新的评审！

自定义你的使用体验

访问你的控制面板以：

  • 启用或禁用评审功能，比如 Sourcery 自动生成的拉取请求摘要、评审者指南等。
  • 更改评审语言。
  • 添加、删除或编辑自定义评审说明。
  • 调整其他评审设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines the arbitrage pipeline configuration used in the shop selling flow by updating the Arbitrage.json resource definition.

File-Level Changes

Change Details Files
Adjust arbitrage pipeline configuration for the shop selling flow.
  • Modify parameters or structure in the arbitrage pipeline JSON used by the selling flow
  • Update configuration values to optimize or correct selling behavior
  • Potentially add, remove, or reorder pipeline steps related to arbitrage processing
 assets/resource/pipeline/Arbitrage.json
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好——我已经审阅了你的修改，看起来非常棒！

Sourcery 对开源项目是免费的——如果你觉得我们的审查有帮助，欢迎分享 ✨
帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的审查。
Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sunyink sunyink merged commit beee116 into main Mar 25, 2026
14 of 15 checks passed
@sunyink sunyink deleted the fix/shopsell branch March 25, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sunyink