Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file joss_paper/joss_paper_plot.py:

Line 27:29: E231 missing whitespace after ','
Line 30:38: E231 missing whitespace after ','
Line 30:51: W605 invalid escape sequence '\m'
Line 30:59: W605 invalid escape sequence '\A'
Line 31:38: E231 missing whitespace after ','
Line 31:53: W605 invalid escape sequence '\m'
Line 31:61: W605 invalid escape sequence '\A'
Line 39:101: E501 line too long (121 > 100 characters)
Line 64:39: E251 unexpected spaces around keyword / parameter equals
Line 64:41: E251 unexpected spaces around keyword / parameter equals

Comment last updated at 2020-02-07 15:50:06 UTC

Thanks for the pull request @Cadair! Everything looks great!

Alright everyone, the policy for JOSS is for the authorship of this paper to match the authorship of the repository. Therefore we are planning on including you unless you opt out. If you don't want to be an author please let us know.

I shall now ping everyone github thinks is a contributor to this repo!

@Cadair @nabobalis @ehsteve @segfaulthunter @khughitt @ayshih @DanRyanIrish @derdon @dpshelio @PritishC @vn-ki @aringlis @Punyaslok @bsipocz @gunner272 @SolarDrew @dstansby @rhewett @Alex-Ian-Hamilton @hayesla @kaichogami @mattearnshaw @nitinkgp23 @ankitkmr @prateekiiest @Akram9 @MSKirk @mdmueller @sudk1896 @haathi @yashkgp @CyclingNinja @abit2 @wtbarnes @Cubostar @m-charlton @samaloney @ndchorley @himanshukgp @s0nskar @yashrsharma44 @jmason86 @Naman9639 @Hypnus1803 @larrymanley @agneet42 @quintusdias @mbobra @souravghosh97 @Airmansmith97

hmm, interesting. Could it be that it actually only notified the first 50 people on the list?

yeah I just confirmed this.

and the rest:

@StanczakDominik @rubendv @vermashresth @ankit-maverick @dumindux @jongyeob @ToyDragon @dhruvgoel2295 @gbear605 @gcetusic @sudozer @mateoi @getsanjeev @cquark7 @embray @jairideout @ddialer @examon @AbhigyanBose @cguennou @drdavella @transientlunatic @JordanBallew @namurphy @thelazy @astrofrog @dodoextinct @astroengisci @eigenbrot @bmampaey @bmwiedemann @cmolinaord @DuyguKeskek @tyaq @entrepreneurj @xuanxu @liftTacos @CaptainDaVinci @abigailStev @adrn @coder006 @kiendang @eamanu @FinMacDov @freekv @gulshan-mittal @harshmathur1990 @ibab @jaylenw @pymilo

and once more:
@martiansideofthemoon @kaustubhhiware @Pac23 @Mmendero @BoboTiG @olebole @rajasekharmekala @talsperre @jains8844 @ytann @tdwilkinson @tiagopereira @yudhik11 @jamescalixto

If you do want to be an author and you want to set your orcid and affiliations please leave an inline comment in the right place in the diff preferably as a suggestion (see step 6 here) so that someone doesn't have to go through them all 🤣

(I have now added all the names generated from git shortlog which isn't the same list as the people I just pinged.)

once you have added your details, you might want to unsubscribe from the issue by clicking the button on the right hand side at the top!!

One other review comment -- considering adding language to address this JOSS review criteria:

State of the field: Do the authors describe how this software compares to other commonly-used packages?

xref openjournals/joss-reviews#1832

If anyone else wants to add author details please edit or leave a comment on metadata.yml.

One other review comment -- considering adding language to address this JOSS review criteria:

State of the field: Do the authors describe how this software compares to other commonly-used packages?

xref openjournals/joss-reviews#1832

@mwcraig We address this in the introduction section of the accompanying ApJ Paper. Does this satisfy the review criteria or would you like us to explicitly address this in the JOSS paper?

@mwcraig We address this in the introduction section of the accompanying ApJ Paper. Does this satisfy the review criteria or would you like us to explicitly address this in the JOSS paper?

Fine question, have asked over on the JOSS issue.

State of the field — adding a brief reference in the JOSS paper to the discussion in the ApJ is sufficient.