Skip to content

Implement .prof output - #13

Merged
sunhailin-Leo merged 1 commit into
sunhailin-Leo:mainfrom
msnidal:feature/dot-prof-support
May 5, 2023
Merged

sunhailin-Leo merged 1 commit into
sunhailin-Leo:mainfrom
msnidal:feature/dot-prof-support

Conversation

@msnidal

@msnidal msnidal commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

Nice profiler! I used it on a project and got some good usage out of it, as #9 raised though there is a lot of Python tooling out there to support .prof files such as snakeviz, etc. so I thought I'd add support for cProfile.

In addition to the new code I added an example and test for it - although the test is rudimentary (it just checks whether the .prof file exists and is non-empty) I had success on my machine getting the .prof output and loading it into snakeviz! Thanks again for the profiler.

Comment thread fastapi_profiler/profiler.py Resolved
Comment thread fastapi_profiler/profiler.py Resolved
@sunhailin-Leo

Copy link
Copy Markdown
Owner

LGTM~

@sunhailin-Leo
sunhailin-Leo merged commit 21ca3c0 into sunhailin-Leo:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants