only freeDictIfNeeded if kvs_it->didx != -1

sundb · sundb · commit ee3efcd897cf · 2025-12-17T20:49:22.000+08:00
diff --git a/src/kvstore.c b/src/kvstore.c
@@ -638,7 +638,8 @@ void kvstoreIteratorReset(kvstoreIterator *kvs_it) {
     dictIterator *iter = &kvs_it->di;
     dictResetIterator(iter);
     /* In the safe iterator context, we may delete entries. */
-    freeDictIfNeeded(kvs_it->kvs, kvs_it->didx);
+    if (kvs_it->didx != -1)
+        freeDictIfNeeded(kvs_it->kvs, kvs_it->didx);
 }
 
 /* Returns next dictionary from the iterator, or NULL if iteration is complete.
@@ -1083,6 +1084,14 @@ int kvstoreTest(int argc, char **argv, int flags) {
         assert(kvstoreSize(kvs2) == 16);
     }
 
+    TEST("kvstoreIterator creating and releasing without kvstoreIteratorNextDict()") {
+        kvstore *kvs = kvstoreCreate(&KvstoreDictNovalTestType, 0, KVSTORE_ALLOCATE_DICTS_ON_DEMAND | KVSTORE_FREE_EMPTY_DICTS);
+        kvstoreIterator kvs_iter;
+        kvstoreIteratorInit(&kvs_iter, kvs);
+        kvstoreIteratorReset(&kvs_iter);
+        kvstoreRelease(kvs);
+    }
+
     TEST("kvstoreIterator case 1: removing all keys does not delete the empty dict") {
         kvstoreIteratorInit(&kvs_it, kvs1);
         while((de = kvstoreIteratorNext(&kvs_it)) != NULL) {
