_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

src/plugins/agents/base.ts (2)

23-70: Well-implemented cross-platform command detection utility.

The function correctly handles:

• Platform detection and appropriate tool selection (where vs which)
• Windows-specific shell: true requirement for PATH resolution
• Multiple path handling from where output
• Timeout with process termination

However, there's a potential race condition: if proc.kill() in the timeout handler fires just before the close event, both could attempt to resolve the Promise. While this won't cause a crash (the second resolve is a no-op), it may lead to inconsistent behaviour where the timeout path reports found: false but the actual process succeeded.

Consider tracking resolution state:

♻️ Suggested improvement

 export function findCommandPath(
   command: string
 ): Promise<{ found: boolean; path: string }> {
   return new Promise((resolve) => {
     const isWindows = platform() === 'win32';
     const whichCmd = isWindows ? 'where' : 'which';
+    let resolved = false;
+
+    const safeResolve = (result: { found: boolean; path: string }) => {
+      if (!resolved) {
+        resolved = true;
+        resolve(result);
+      }
+    };

     const proc = spawn(whichCmd, [command], {
       stdio: ['ignore', 'pipe', 'pipe'],
       shell: isWindows,
     });

     let stdout = '';

     proc.stdout?.on('data', (data: Buffer) => {
       stdout += data.toString();
     });

     proc.on('error', () => {
-      resolve({ found: false, path: '' });
+      safeResolve({ found: false, path: '' });
     });

     proc.on('close', (code) => {
       if (code === 0 && stdout.trim()) {
         const firstPath = stdout.trim().split(/\r?\n/)[0] ?? '';
-        resolve({ found: true, path: firstPath.trim() });
+        safeResolve({ found: true, path: firstPath.trim() });
       } else {
-        resolve({ found: false, path: '' });
+        safeResolve({ found: false, path: '' });
       }
     });

     setTimeout(() => {
       proc.kill();
-      resolve({ found: false, path: '' });
+      safeResolve({ found: false, path: '' });
     }, 5000);
   });
 }

---

72-72: Unconventional import placement.

The import statement at line 72 appears after the findCommandPath function definition. While syntactically valid due to hoisting, this is an unusual pattern that may confuse readers. Consider moving it to the top of the file with other imports.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

• X
• Mastodon
• Reddit
• LinkedIn