Centralize agent configuration resolution logic by subsy · Pull Request #229 · subsy/ralph-tui

subsy · 2026-01-26T17:13:33Z

Summary

This PR refactors agent configuration resolution to use a centralized getDefaultAgentConfig() function across all commands and components. This eliminates duplicate logic for determining which agent to use and ensures consistent handling of agent configuration, including command overrides and environment variable settings.

Key Changes

Exported getDefaultAgentConfig() function from src/config/index.ts to make it available throughout the codebase. This function implements a clear precedence order for agent selection:
1. CLI override (options.agent)
2. Shorthand storedConfig.agent field
3. defaultAgent setting
4. Agent marked with default: true in agents array
5. First agent in agents array
6. Built-in claude plugin
Updated doctor.ts command to use getDefaultAgentConfig() instead of inline agent selection logic. Now properly passes the full agent configuration (including command, envExclude, envPassthrough) to registry.getInstance().
Updated info.ts command to use getDefaultAgentConfig() for consistent agent resolution. Added command field to the SystemInfo.agent interface and displays custom command paths in the formatted output.
Updated run.tsx and RunApp.tsx to accept and pass through the agentCommand property. The display name now shows the custom command in parentheses when configured (e.g., "claude (claude-glm)").
Simplified environment variable resolution in both doctor.ts and info.ts by relying on the pre-resolved settings in agentConfig rather than manually merging agent-level and top-level settings.

Implementation Details

The getDefaultAgentConfig() function returns an AgentPluginConfig object that includes all necessary configuration: name, plugin, options, command, envExclude, and envPassthrough.
Agent-level environment settings now properly take precedence over top-level settings through the centralized function.
The refactoring maintains backward compatibility while reducing code duplication and improving maintainability.

Summary by CodeRabbit

New Features
- Custom agent commands now configurable per agent within configuration
- Agent-level commands take precedence over top-level configuration settings
- Custom agent command paths now displayed in system information output and user interface
- Enhanced default agent selection mechanism for agent configuration arrays
Tests
- Added tests for agent configuration propagation and command precedence scenarios

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Fixes #220 - Custom Claude Code command not being used. Changes: - Export getDefaultAgentConfig() from config/index.ts for reuse - Update doctor.ts to use centralized config resolution (includes command) - Update info.ts to use centralized config resolution and display command - Add agentCommand prop to RunApp and RunAppWrapper components - Display custom command in brackets in UI (e.g., "claude (claude-glm)") The issue was that diagnostic commands (doctor, info) were manually building agent configs without checking the [[agents]] array for agents with default=true and their custom command settings. Now all agent config resolution uses the centralized getDefaultAgentConfig() which properly: 1. Checks CLI override 2. Checks shorthand agent field 3. Checks stored defaultAgent 4. Finds agent with default: true in agents array 5. Falls back to first agent or built-in claude

vercel · 2026-01-26T17:13:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
ralph-tui	Ignored	Preview	Jan 26, 2026 5:17pm

coderabbitai · 2026-01-26T17:13:44Z

Walkthrough

This pull request centralises agent command configuration by exporting getDefaultAgentConfig as a public API and propagating per-agent command settings through the doctor, info, and run command flows. The changes thread the agent command value from configuration resolution through agent instantiation and into the TUI display layer.

Changes

Cohort / File(s)	Summary
Agent Configuration Core `src/config/index.ts`	Exports `getDefaultAgentConfig` function to public API with expanded JSDoc documentation detailing resolution order; enables centralised agent config resolution across commands.
Doctor Command `src/commands/doctor.ts`, `src/commands/doctor.test.ts`	Uses centralised `getDefaultAgentConfig` to resolve agent configuration; passes full `agentConfig` object to `registry.getInstance` instead of manual construction; updates error messaging and environment exclusion reporting to reference agent config fields. Adds test cases verifying agent command precedence and config propagation.
Info Command `src/commands/info.ts`, `src/commands/info.test.ts`	Integrates `getDefaultAgentConfig` for centralized agent resolution; adds optional `command?: string` field to `SystemInfo.agent`; switches environment exclusion reporting to use `agentConfig.envPassthrough` and `agentConfig.envExclude`; updates `formatSystemInfo` to display custom agent command when present. Extends tests to verify agent command collection and display.
Run Command & UI `src/commands/run.tsx`, `src/tui/components/RunApp.tsx`	Adds optional `agentCommand?: string` prop to `RunAppWrapperProps` interface and threads it through component hierarchy from configuration to `RunApp`; enhances local agent display logic to show custom command in parentheses (e.g., "claude (claude-glm)") when present.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

feat: add top-level 'command' config for custom agent executables #119: Introduced the top-level command shorthand and its mapping into getDefaultAgentConfig, which this PR directly uses for agent command propagation.
fix: pass command config to agent in create-prd and doctor commands #191: Modified doctor.ts to propagate per-agent command and environment settings into registry.getInstance, sharing the same config propagation pattern.
Add environment variable passthrough allowlist for blocked vars #207: Modified agent config resolution and wired per-agent fields (envPassthrough/envExclude and agent command) through doctor/info/run flows using the same getDefaultAgentConfig approach.

Poem

🐰 The config now speaks with unified voice,
Agent commands thread through each choice,
From doctor to info to run's grand display,
Commands hop centre-stage, no delay!
Centralised wisdom, the path made clear— 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarises the main change—centralising agent configuration resolution logic—which is the primary refactoring across multiple files in the pull request.
Docstring Coverage	✅ Passed	Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-26T17:14:48Z

Codecov Report

❌ Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.93%. Comparing base (efd1ff6) to head (4facc45).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/doctor.ts	42.10%	11 Missing ⚠️
src/commands/run.tsx	0.00%	3 Missing ⚠️
src/commands/info.ts	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   44.93%   44.93%   -0.01%     
==========================================
  Files          84       84              
  Lines       24475    24479       +4     
==========================================
+ Hits        10998    10999       +1     
- Misses      13477    13480       +3

Files with missing lines	Coverage Δ
src/config/index.ts	`54.28% <100.00%> (+1.22%)`	⬆️
src/commands/info.ts	`76.58% <86.66%> (-0.64%)`	⬇️
src/commands/run.tsx	`8.27% <0.00%> (-0.02%)`	⬇️
src/commands/doctor.ts	`78.80% <42.10%> (-3.17%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds tests for the new centralized getDefaultAgentConfig usage: doctor.test.ts: - Test that agents from [[agents]] array with default=true and command are used - Test that agent-level command takes precedence over top-level command info.test.ts: - Test that agents from [[agents]] array with default=true are resolved - Test that custom command is included in SystemInfo - Test that command is displayed in formatSystemInfo output - Test that command is undefined when not configured

subsy · 2026-01-26T19:46:01Z

@coderabbitai review

coderabbitai · 2026-01-26T19:46:11Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…MQXTJ Centralize agent configuration resolution logic

subsy merged commit 07d8bc8 into main Jan 26, 2026
9 checks passed

subsy deleted the claude/investigate-issue-220-MQXTJ branch January 26, 2026 21:22

This was referenced Jan 30, 2026

feat: add file browser component for PRD file selection #236

Closed

feat(tui): Add split worker/reviewer output with Tab navigation and focus management #272

Open

coderabbitai bot mentioned this pull request Feb 14, 2026

Fix custom agents missing in settings (issue 287) #304

Merged

sakaman pushed a commit to sakaman/ralph-tui that referenced this pull request Feb 15, 2026

Merge pull request subsy#229 from subsy/claude/investigate-issue-220-…

e6e40cc

…MQXTJ Centralize agent configuration resolution logic

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Centralize agent configuration resolution logic#229

Centralize agent configuration resolution logic#229
subsy merged 2 commits intomainfrom
claude/investigate-issue-220-MQXTJ

subsy commented Jan 26, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

subsy commented Jan 26, 2026

Uh oh!

coderabbitai bot commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

subsy commented Jan 26, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Implementation Details

Summary by CodeRabbit

Uh oh!

vercel bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

codecov bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

subsy commented Jan 26, 2026

Uh oh!

coderabbitai bot commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

subsy commented Jan 26, 2026 •

edited by coderabbitai bot

Loading

vercel bot commented Jan 26, 2026 •

edited

Loading

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

codecov bot commented Jan 26, 2026 •

edited

Loading