Conversation
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
core/btdiscovery.cpp
Outdated
| report_info("Paired = %s %s", qPrintable( btPairedDevices[i].name), qPrintable(btPairedDevices[i].address)); | ||
| if (verbose) | ||
| for (int i = 0; i < btPairedDevices.length(); i++) | ||
| report_info("Paired = %s %s", qPrintable( btPairedDevices[i].name), qPrintable(btPairedDevices[i].address)); |
There was a problem hiding this comment.
nitpick:
| report_info("Paired = %s %s", qPrintable( btPairedDevices[i].name), qPrintable(btPairedDevices[i].address)); | |
| report_info("Paired = %s %s", qPrintable(btPairedDevices[i].name), qPrintable(btPairedDevices[i].address)); |
| if (message.contains("Updating RSSI for") || (message.contains(QRegularExpression(".*kirigami.*onFoo properties in Connections")))) | ||
| if (message.contains("Updating RSSI for") || | ||
| message.contains("Updating manufacturer data for") || | ||
| message.contains("Almost Duplicate") || |
There was a problem hiding this comment.
sarcasm: Almost worth logging...
core/btdiscovery.cpp
Outdated
| QHash<QString, QBluetoothDeviceInfo> btDeviceInfo; | ||
| QSet<QString> btMessages; | ||
| } | ||
| static bool dedupBtMessages(const QString &msg); |
There was a problem hiding this comment.
question: Not quite sure why we need the forward declaration here?
There was a problem hiding this comment.
I got a weird error at compile time about a function with out declaration. I assumed it was a C++ thing I didn't understand, honestly.
There was a problem hiding this comment.
tried again and it's fine. force push incoming
Especially when looking at logs from mobile devices the BLE messages tend to completely drown out all useful content. Let's try and pair this back a bit. Signed-off-by: Dirk Hohndel <[email protected]>
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
2 participants
Especially when looking at logs from mobile devices the BLE messages tend to completely drown out all useful content. Let's try and pair this back a bit.
Describe the pull request: