cleanup: avoid crash initializing std::string from NULL#4745
Merged
Conversation
Signed-off-by: Dirk Hohndel <[email protected]>
mikeller
approved these changes
Mar 9, 2026
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
cleaned up version of the earlier change
Changes made:
Mentions:
@mikeller
why do I even submit this separately? Because the Android build setup and version numbering for the Play Store was designed with the idea that I'd need no more than 9 extra build between BuildNumber changes.
But since we haven't merged a PR in a few days, I'm running out of version numbers for the package in order to submit new test builds to Google 🤣
Hopefully with the cleaned up language this is uncontroversial enough to just get merged 😇