-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use class for diagnostic info instead of hardcoding color #2257
Conversation
Also we had this existing issue where the "related info" did not have a line break before it in the diagnostic panel. Before: After: The HTML in the quick panel preview seems to be more limited so applying styles from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot don't look right to me, why is there a linebreak before the link (and also before the closing I think instead of having the |
I think the intentions of @predragnikolic were not to achieve something nice looking but just test that overrides work. We could try to have one color-muted wrapper but there is an optional link inside that element so not sure how will it work. |
There was some custom CSS that caused such behavior :) I still didn't try to make it pretty, but I just tested that it is possible to target the class name.
Yes
And yes |
Looks good to me, |
Looks good to me too, but only one small nitpick, that I would not include the leading space in the - meta_info = " "
+ html = " " should do it. |
* main: fix "Error rewriting command" warning triggered on startup (#2277) Take font style of sighelp active parameter from color scheme (#2279) Add argument "include_declaration" to "lsp_symbol_references" (#2275) fix crash on checking excluded folders with missing project data (#2276) Fix tagged diagnostics flickering on document changes (#2274) Cut 1.24.0 use class for diagnostic info instead of hardcoding color (#2257) Fix package storage path in a docstring description (#2256) Use regular font style in sighelp popup if already highlighted by color scheme (#2259) update note about custom color scheme rule used for diagnostics (#2254)
Use
.color-muted
class instead of hardcoding color when showing diagnostic info.Changed opacity of
.color-muted
from0.5
to0.6
. Should still be fine and is more consistent with other places.Fixes #2255