Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can I change the color of this? #2255

Closed
maclam opened this issue May 13, 2023 · 4 comments · Fixed by #2257
Closed

How can I change the color of this? #2255

maclam opened this issue May 13, 2023 · 4 comments · Fixed by #2257

Comments

@maclam
Copy link

maclam commented May 13, 2023

Is your feature request related to a problem? Please describe.
I didn't find anything in your documentation to change this part in white, or maybe I am blind?
It's annoying because it's unreadable, I would like to keep the background yellow for the warnings.

unreadable

Here is my mdpopups.css file:

html.dark {
    background-color: #252525;
    color: #9f9f9f;
}

.dark .mdpopups .highlight {
    background-color: #0f0f0f;
}

html.light {
    background-color: #e5e5e5;
    color: #666666;
}

.light .mdpopups .highlight {
    background-color: #fff;
}

html {
    --mdpopups-font-mono: "Operator Mono Book";
}

.errors a,
.warnings a {
    display: block;
    color: #010192;
    margin-top: 0.5rem;
}

.lsp_popup .errors {
    border-width: 0;
    background-color: #fd3434;
    color: #0f0f0f;
    margin-bottom: 0.5rem;
    padding: 0.5rem;
}

.lsp_popup .warnings {
    border-width: 0;
    background-color: #feff60;
    color: #0f0f0f;
    margin-bottom: 0.5rem;
    padding-top: 0.5rem;
}

.lsp_popup .info {
    border-width: 0;
    background-color: #00bfff;
    color: #0f0f0f;
    margin-bottom: 0.5rem;
    padding-top: 0.5rem;
}

.lsp_popup .hints {
    border-width: 0;
    background-color: #f8f8f8;
    color: #0f0f0f;
    margin-bottom: 0.5rem;
    padding-top: 0.5rem;
}

Describe the solution you'd like
Add an option to be able to modify this color if possible.

Thank you very much and again for your hard work 🙏.
@jwortmann
Copy link
Member

I don't think you can. It's hardcoded currently

LSP/plugin/core/views.py

Lines 998 to 1007 in 346599a

if source:
formatted.append(_with_color(source, "color(var(--foreground) alpha(0.6))"))
if code is not None:
formatted.append(_with_color("(", "color(var(--foreground) alpha(0.6))"))
code_description = diagnostic.get("codeDescription")
if code_description:
formatted.append(make_link(code_description["href"], str(code)))
else:
formatted.append(_with_color(str(code), "color(var(--foreground) alpha(0.6))"))
formatted.append(_with_color(")", "color(var(--foreground) alpha(0.6))"))

This code should be replaced with a CSS class and the color moved into popups.css. Then you could adjust it via mdpopups.css.

@rchl rchl mentioned this issue May 14, 2023
Merged
@maclam
Copy link
Author

maclam commented May 14, 2023

I just tested your fix and this is what I get:

wrong

Oops

@rchl
Copy link
Member

rchl commented May 14, 2023 •
edited
Loading

You have to pull latest changes. It was broken for a short while.

Also note that you should override the .lsp_popup .color-muted selector when using this fix.

@maclam
Copy link
Author

maclam commented May 14, 2023

Oh ok, sorry for the inconvenience.
I'll wait for the next update ;-)

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use class for diagnostic info instead of hardcoding color sublimelsp/LSP
3 participants
@rchl @jwortmann @maclam