[PHP] PHP 8.0 new syntax #2275
Merged
[PHP] PHP 8.0 new syntax #2275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcherng
force-pushed
the
feat-php-8
branch
2 times, most recently
from
2391691 to
cd56bac
Compare
jfcherng
force-pushed
the
feat-php-8
branch
6 times, most recently
from
31d8d4b to
0c1d9ce
Compare
jfcherng
force-pushed
the
feat-php-8
branch
9 times, most recently
from
73673c6 to
6b011a2
Compare
jfcherng
force-pushed
the
feat-php-8
branch
3 times, most recently
from
dabc21e to
16d4221
Compare
jfcherng
force-pushed
the
feat-php-8
branch
3 times, most recently
from
5a15884 to
43c8cd3
Compare
Member
|
Based on your comment, this shouldn't really be reviewed until August, right? |
Collaborator
Author
Correct but I don't mind creating another PR if you would like to merge this one now. All known PHP 8 features currently should've been done. I am not sure whether there will be more features to be added by August. |
jfcherng
force-pushed
the
feat-php-8
branch
2 times, most recently
from
1304e44 to
a4882bd
Compare
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
https://wiki.php.net/rfc/attributes_v2 https://wiki.php.net/rfc/attribute_amendments https://wiki.php.net/rfc/shorter_attribute_syntax Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
Fixes sublimehq#991 Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
php/php-src#5427 Signed-off-by: Jack Cherng <[email protected]>
php/php-src#5216 Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
wbond
requested changes
Jul 21, 2020
Member
wbond
left a comment
wbond
left a comment
There was a problem hiding this comment.
Looks generally good to me - just some section scope fixes and I will be ready to merge.
Signed-off-by: Jack Cherng <[email protected]>
Member
|
Awesome, thanks for all of these updates! |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [PHP] Add some built-in classes and constants Classes: ArgumentCountError ArithmeticError CompileError DivisionByZeroError Error ParseError Stringable TypeError ValueError WeakMap WeakReference --- Constants: FILTER_VALIDATE_BOOL --- https://github.com/symfony/polyfill-php80 https://wiki.php.net/rfc/stringable https://wiki.php.net/rfc/weak_maps https://www.php.net/manual/en/reserved.exceptions.php https://www.php.net/manual/en/spl.exceptions.php * [PHP] Add support for union types https://wiki.php.net/rfc/union_types_v2 * [PHP] Add support for "static" return type https://wiki.php.net/rfc/static_return_type * [PHP] Add core function: str_contains https://wiki.php.net/rfc/str_contains * [PHP] Add core function: get_debug_type * [PHP] Add built-in class: DateTimeImmutable, DateTimeInterface * [PHP] Add core function: fdiv php/php-src#4769 * [PHP] Add built-in class: PhpToken https://wiki.php.net/rfc/token_as_object * [PHP] Add core function: str_starts_with, str_ends_with https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions * [PHP] Add support for short attributes ("@@") https://wiki.php.net/rfc/attributes_v2 https://wiki.php.net/rfc/attribute_amendments https://wiki.php.net/rfc/shorter_attribute_syntax * [PHP] Add support for "mixed" type hinting https://wiki.php.net/rfc/mixed_type_v2 * [PHP] Add support for constructor property promotion https://wiki.php.net/rfc/constructor_promotion * [PHP] Extract visibility modifier as a variable * [PHP] Add missing constant: DNS_CAA Fixes sublimehq#991 * [PHP] Add support for "match" expression https://wiki.php.net/rfc/match_expression_v2 * [PHP] Add snippet: fn ... * [PHP] Add snippet: match ... * [PHP] Add support for named arguments https://wiki.php.net/rfc/named_params * [PHP] Add support for nullsafe operator https://wiki.php.net/rfc/nullsafe_operator * [PHP] Add core function: get_resource_id php/php-src#5427 * [PHP] Add built-in class: InternalIterator php/php-src#5216 * [PHP] Syntax definition use "version: 2" * [PHP] Fix punctuation scopes have no begin/end
Contributor
|
@jfcherng I just noticed that named parameters are not working for function calls when they are closures stored in an array. Example: $array = [
'callback' => function ($first, $second) {
echo "{$first}, {$second}";
},
];
$array['callback'](first: 'first', second: 'second');The closing parentheses is not highlighted correctly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 is scheduled to be feature-freezed on August 4 2020.
References:
PHP 8.0 New Syntax-related Things
Need new parsing paths
Just some simple supplements
Snippets
Others
version: 2