Skip to content

Deduplicate path helpers in delete.rs - #1

Closed
lifrary wants to merge 1 commit into
subinium:mainfrom
lifrary:cleanup/dedup-path-helpers
Closed

lifrary wants to merge 1 commit into
subinium:mainfrom
lifrary:cleanup/dedup-path-helpers

Conversation

@lifrary

@lifrary lifrary commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

delete.rs had private home_dir(), claude_dir(), and codex_dir() functions that duplicated the same logic already exposed as public in config.rs. This removes the copies and reuses the existing ones, converting the error type at the call site.

delete.rs defined its own home_dir(), claude_dir(), and codex_dir()
that duplicated the same logic already public in config.rs. Reuse the
existing functions and convert the error type at the call site.
subinium added a commit that referenced this pull request Feb 18, 2026
Reuse config::claude_dir(), config::codex_dir(), and
config::opencode_data_dir() instead of private duplicates.

Co-Authored-By: SEUNGWOO LEE <[email protected]>
@subinium

Copy link
Copy Markdown
Owner

Merged manually after resolving conflicts with OpenCode support (v0.2.1). Also applied the same deduplication to opencode_data_dir(). Thanks!

@subinium subinium closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants