Skip to content

throw a more specific exception on malformed project reference strings #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markphip merged 1 commit into from
Mar 8, 2017
Merged

throw a more specific exception on malformed project reference strings #25

markphip merged 1 commit into from
Mar 8, 2017

Conversation

@jhonnen
Copy link
Contributor

@jhonnen jhonnen commented Mar 8, 2017

We generate our project set file from SVN. On occasion the generated reference string is malformed like that:

<project reference="0.9.3,https://host/svn/path/to/plugin"/> (--> the plugin name is missing)

In that case the team project set import just throws the following error:

An internal error occurred during: "Importing project set...".

java.util.NoSuchElementException
	at java.util.StringTokenizer.nextToken(StringTokenizer.java:349)
	at org.tigris.subversion.subclipse.core.SVNProjectSetCapability$LoadInfo.<init>(SVNProjectSetCapability.java:213)
	at org.tigris.subversion.subclipse.core.SVNProjectSetCapability.asProjects(SVNProjectSetCapability.java:143)
	at org.tigris.subversion.subclipse.core.SVNProjectSetCapability.addToWorkspace(SVNProjectSetCapability.java:107)
	at org.eclipse.team.internal.ui.ProjectSetImporter.importProjectSet(ProjectSetImporter.java:109)
	at org.eclipse.team.internal.ui.ProjectSetImporter.importProjectSet(ProjectSetImporter.java:67)
	at org.eclipse.team.internal.ui.wizards.ImportProjectSetOperation.runForFile(ImportProjectSetOperation.java:84)
	at org.eclipse.team.internal.ui.wizards.ImportProjectSetOperation.run(ImportProjectSetOperation.java:100)
	at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:151)
	at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:76)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

With my changes the following error would be shown:

An internal error occurred during: "Importing project set...".
java.lang.IllegalArgumentException: malformed project reference: 0.9.3,https://host/svn/path/to/plugin
	...

@markphip markphip merged commit 13afe0e into subclipse:master Mar 8, 2017
@markphip
Copy link
Contributor

markphip commented Mar 8, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhonnen @markphip @JulianJho