Skip to content

NPE in ConfigurableMergeAction#selectionChanged #77

@jhonnen

Description

@jhonnen

With subclipse 4.2.7 and eclipse 4.9 the following NPE occurs sporadically on text selections:

java.lang.NullPointerException
	at org.tigris.subversion.subclipse.ui.internal.TeamAction.selectionChanged(TeamAction.java:256)
	at org.tigris.subversion.subclipse.ui.actions.ConfigurableMergeAction.selectionChanged(ConfigurableMergeAction.java:23)
	at org.eclipse.ui.internal.PluginAction.refreshEnablement(PluginAction.java:209)
	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:276)
	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:300)
	at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyListeners(SelectionService.java:242)

The exception is thrown because getTargetPart().getSite().getPage() returns null. The action's target part is a disposed editor. The PartSite of disposed parts no longer has a reference to its original workbench page (since eclipse 4.9, see Bug 536677).

ConfigurableMergeAction#setActivePart(IAction, IWorkbenchPart) is apparently never called.

Full stacktrace: stacktrace.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions