Skip to content

[WIP] Turbulent kinetic energy based on inlet condition for supersonic inlet#2430

Merged
pcarruscag merged 11 commits intodevelopfrom
feature_tke_supersonic
Mar 10, 2025
Merged

[WIP] Turbulent kinetic energy based on inlet condition for supersonic inlet#2430
pcarruscag merged 11 commits intodevelopfrom
feature_tke_supersonic

Conversation

@Cristopher-Morales
Copy link
Copy Markdown
Contributor

@Cristopher-Morales Cristopher-Morales commented Jan 23, 2025

Proposed Changes

Allow use of turbulent market for supersonic inlet where turbulent kinetic energy is computed based on the turbulent intensity provided at the inlets

Related Work

Consistent with previous pull request #1843

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • [X ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Cristopher-Morales Cristopher-Morales changed the title Turbulent kinetic energy based on inlet condition for supersonic inlet [WIP] Turbulent kinetic energy based on inlet condition for supersonic inlet Jan 23, 2025
@rois1995
Copy link
Copy Markdown
Contributor

rois1995 commented Jan 23, 2025

Can you try a case with supersonic inlet and check if the mach number is computed correctly at the inlet?

@Cristopher-Morales
Copy link
Copy Markdown
Contributor Author

Cristopher-Morales commented Feb 4, 2025 •
edited
Loading

Can you try a case with supersonic inlet and check if the mach number is computed correctly at the inlet?

supersonic
top : develop
bottom : current pull request

V&V case Shock-Wave Boundary-Layer Interaction https://su2code.github.io/vandv/swbli/

@pcarruscag
Copy link
Copy Markdown
Member

pcarruscag commented Feb 4, 2025

Cool, so it this still WIP or it's pretty much ready?

@Cristopher-Morales
Copy link
Copy Markdown
Contributor Author

Cristopher-Morales commented Feb 5, 2025

Cool, so it this still WIP or it's pretty much ready?

It is ready, thanks!!

@Cristopher-Morales Cristopher-Morales changed the title [WIP] Turbulent kinetic energy based on inlet condition for supersonic inlet Turbulent kinetic energy based on inlet condition for supersonic inlet Feb 5, 2025
pcarruscag
pcarruscag reviewed Feb 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify a testcase to exercise this, the default is probably the same as freestream.

pcarruscag
pcarruscag reviewed Feb 5, 2025
View reviewed changes
@Cristopher-Morales
Copy link
Copy Markdown
Contributor Author

Cristopher-Morales commented Feb 5, 2025

Please modify a testcase to exercise this, the default is probably the same as freestream.

Thanks! I will do it.

@Cristopher-Morales Cristopher-Morales changed the title Turbulent kinetic energy based on inlet condition for supersonic inlet [WIP] Turbulent kinetic energy based on inlet condition for supersonic inlet Mar 7, 2025
@pcarruscag pcarruscag merged commit 3bf94ea into develop Mar 10, 2025
34 of 35 checks passed
@pcarruscag pcarruscag deleted the feature_tke_supersonic branch March 10, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag left review comments

Assignees

No one assigned

Labels

changelog:feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cristopher-Morales @rois1995 @pcarruscag