Skip to content

Fix meson issues#2093

Merged
pcarruscag merged 2 commits intodevelopfrom
fix_meson_issues
Jul 28, 2023
Merged

Fix meson issues#2093
pcarruscag merged 2 commits intodevelopfrom
fix_meson_issues

Conversation

@jblueh
Copy link
Copy Markdown
Contributor

@jblueh jblueh commented Jul 27, 2023 •
edited
Loading

Proposed Changes

This PR fixes small issues in the meson build system that I noticed during recent work on SU2.

  1. deprecation warnings about meson.source_root()
  2. an incorrectly displayed ninja command

PR Checklist

pcarruscag
pcarruscag approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these

@jblueh
Copy link
Copy Markdown
Contributor Author

jblueh commented Jul 28, 2023

Thank you for fixing these

Thanks for the approval @pcarruscag. I can't merge though, the formatting workflow seems to be stuck?

@pcarruscag
Copy link
Copy Markdown
Member

pcarruscag commented Jul 28, 2023

Interesting

@pcarruscag pcarruscag merged commit 8105a75 into develop Jul 28, 2023
@pcarruscag pcarruscag deleted the fix_meson_issues branch July 28, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jblueh @pcarruscag