Deprecate CUSP scheme and make it an error to use MUSCL_FLOW=YES with centered schemes#1990
Merged
pcarruscag merged 6 commits intodevelopfrom Mar 29, 2023
Merged
Deprecate CUSP scheme and make it an error to use MUSCL_FLOW=YES with centered schemes#1990pcarruscag merged 6 commits intodevelopfrom
pcarruscag merged 6 commits intodevelopfrom
Conversation
WallyMaier
approved these changes
Mar 28, 2023
Contributor
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
LGTM. I have had terrible success with CUSP as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I never found this scheme to be useful (not an improvement in either accuracy or robustness) and it is not used in any tests.
MUSCL_FLOW= YES is currently ignored for centered schemes, if we ever want to change that it would lead to backward compatibility issues, since we now have a chance to break it, I'm disallowing setting MUSCL_FLOW= YES with centered schemes.
PR Checklist