Generalized, quasi 3D look-up table#1825
Conversation
… class with x and y
…as they're redundant. Added a 3D table unit test case
…el would not be selected properly
pcarruscag
left a comment
There was a problem hiding this comment.
Anything else on your side @bigfooted ?
@pcarruscag |
pcarruscag
left a comment
There was a problem hiding this comment.
Ok you can figure out the order you want to merge things.
LGTM
Proposed Changes
Generalize the variables in the CLookUpTable class for use in general look-up cases (not only progress variable-enthalpy).
Add dimension to CLookUpTable class to allow for quasi-3D interpolation (linear interpolation between two trapezoidal maps stacked in the third dimension).
I added a unit test as a test case with the quasi-3D table to show the correct use of syntax for 3D look-up operations.
Related Work
Can be used in feature_multilayer_perceptron in the CDataDrivenFluid fluid model for look-up operations.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.