Source term for axisymmetry in species transport#1785
Merged
bigfooted merged 33 commits intosu2code:developfrom Oct 12, 2022
Merged
Source term for axisymmetry in species transport#1785bigfooted merged 33 commits intosu2code:developfrom
bigfooted merged 33 commits intosu2code:developfrom
Conversation
pcarruscag
reviewed
Oct 7, 2022
pcarruscag
changed the title
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
bigfooted
reviewed
Oct 10, 2022
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Contributor
|
@lkusch if it's good to go, please remove WIP from the title. |
pcarruscag
reviewed
Oct 11, 2022
lkusch
changed the title
bigfooted
reviewed
Oct 11, 2022
bigfooted
reviewed
Oct 11, 2022
pcarruscag
reviewed
Oct 11, 2022
pcarruscag
approved these changes
Oct 11, 2022
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
This LGTM but it would be good to use in a regression at some point.
It would be good to have start having some more formal V&V for species transport @bigfooted @Cristopher-Morales
Contributor
Good, we'll add these V&V, the results from my first attempt after a 2 week su2 crash course with Tom: https://su2code.github.io/documents/dev_meeting_2018/03_su2_dev_beishuizen.pdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds the source term for axisymmetry to the residual computation for species transport. The source term is zero for non-axisymmetric cases.
Related Work
This builds upon the closed pull request #1762 and is connected to #card-71271518 as an aspect of feature_flamelet.
The change uses the implementation by @bigfooted on feature_flamelet. The implemented source term was checked against literature/own derivation by @Cristopher-Morales.
I would like to set up a regression test as soon as #1784 is merged.
PR Checklist