Skip to content

Remove frictional wall heating from incompressible wall function model#1741

Merged
bigfooted merged 11 commits intodevelopfrom
update_wallfunctions
Aug 24, 2022
Merged

Remove frictional wall heating from incompressible wall function model#1741
bigfooted merged 11 commits intodevelopfrom
update_wallfunctions

Conversation

@bigfooted
Copy link
Copy Markdown
Contributor

@bigfooted bigfooted commented Aug 23, 2022

Proposed Changes

The wall function model of Nichols and Nelson was basically implemented in the same way for the compressible and the incompressible solver. But for the incompressible solver, the frictional heating part does not make sense, so it is removed. In the compressible part, some lines have been moved to make comparison between the comp/incomp model easier.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

Copy link
Copy Markdown
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigfooted bigfooted changed the title [WIP] remove frictional wall heating from incompressible wall function model remove frictional wall heating from incompressible wall function model Aug 24, 2022
@bigfooted bigfooted merged commit 0490bdb into develop Aug 24, 2022
@bigfooted bigfooted deleted the update_wallfunctions branch August 24, 2022 05:39
@pcarruscag pcarruscag changed the title remove frictional wall heating from incompressible wall function model Remove frictional wall heating from incompressible wall function model Aug 25, 2022
@bigfooted bigfooted restored the update_wallfunctions branch August 30, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants