Skip to content

Temporarily remove mass diffusion from surface energy balance#1400

Merged
jtneedels merged 2 commits intodevelopfrom
feature_sumJhs_retract
Oct 12, 2021
Merged

Temporarily remove mass diffusion from surface energy balance#1400
jtneedels merged 2 commits intodevelopfrom
feature_sumJhs_retract

Conversation

@jtneedels
Copy link
Copy Markdown
Contributor

@jtneedels jtneedels commented Oct 11, 2021

Proposed Changes

  • Temporarily remove sumJhs term from surface energy balance. The species density gradients provided by WLS and GG are very different, and the GG values give incorrect results for surface heating. I want to remove this term for now, until the gradient difference sorted, so it does not result in incorrect surface heating prediction if the user specifies GG.

Related Work

This reverts the changes in PR #1383

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Signed-off-by: jtneedels <[email protected]>
Signed-off-by: jtneedels <[email protected]>
@jtneedels jtneedels changed the title Temporarily pull mass diffusion from surface energy balance Temporarily remove mass diffusion from surface energy balance Oct 11, 2021
@jtneedels jtneedels merged commit b4b3776 into develop Oct 12, 2021
@jtneedels jtneedels deleted the feature_sumJhs_retract branch October 12, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants