Intermediate class of variable for all flow solver variables + Fix for MUSCL in NEMO solver#1375
Merged
pcarruscag merged 16 commits intodevelopfrom Sep 25, 2021
Merged
Intermediate class of variable for all flow solver variables + Fix for MUSCL in NEMO solver#1375pcarruscag merged 16 commits intodevelopfrom
pcarruscag merged 16 commits intodevelopfrom
Conversation
pcarruscag
commented
Sep 19, 2021
pcarruscag
commented
Sep 19, 2021
pcarruscag
commented
Sep 19, 2021
Contributor
|
@pcarruscag LGTM! Thanks for putting in the work and abstracting more of the repeated routines. |
WallyMaier
approved these changes
Sep 20, 2021
pcarruscag
changed the title
TobiKattmann
approved these changes
Sep 22, 2021
Contributor
TobiKattmann
left a comment
TobiKattmann
left a comment
There was a problem hiding this comment.
Thanks @pcarruscag 💐 Some generalization is always nice. I only a have a few minor points.
I'll try to finish #1330 (template the ScalarLayer on the specialized type of variable), so this can be merged
Co-authored-by: TobiKattmann <[email protected]>
WallyMaier
reviewed
Sep 22, 2021
Co-authored-by: Wally Maier <[email protected]>
Co-authored-by: TobiKattmann <[email protected]>
This was referenced Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Likewise for incompressible and NEMO.
CFlowVariable stores, allocates, and gives access to, primitives, their gradients and limiters, and a few other odd things.
For now this is just cleanup but it can be used to give non-virtual access to these flow variables to other solvers.
For example, the scalar solver #1330 can static_cast or dynamic_cast the nodes of the flow solver to access some quantities more efficiently.
I'll leave that for after #1330 is merged.
PR Checklist