Skip to content

Update SU2-python 2.0#1359

Merged
Nicola-Fonzi merged 3 commits intosu2code:developfrom
Nicola-Fonzi:publish
Aug 24, 2021
Merged

Update SU2-python 2.0#1359
Nicola-Fonzi merged 3 commits intosu2code:developfrom
Nicola-Fonzi:publish

Conversation

@Nicola-Fonzi
Copy link
Copy Markdown
Contributor

@Nicola-Fonzi Nicola-Fonzi commented Aug 24, 2021 •
edited
Loading

Proposed Changes

Just small changes suggested by @TobiKattmann (Thank you) in #1357

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@Nicola-Fonzi Nicola-Fonzi mentioned this pull request Aug 24, 2021
Merged
5 tasks
TobiKattmann
TobiKattmann approved these changes Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nicola-Fonzi 💐

As my review was too late, it would have been totally fine to just do a local commit and share (and reference it) with the next PR 👍

Just one more question: Can the features that should be run only in serial mode, be run in parallel by accident without throwing some error like The combination ... only allows for serial execution of the code.. If not I would appreciate those kinds of checks that prevent use out of spec.

@Nicola-Fonzi
Copy link
Copy Markdown
Contributor Author

Nicola-Fonzi commented Aug 24, 2021

I definitely closed #1357 too fast, so no problem. I tried to implement all your suggestions. Regarding the possibility of running by error in parallel the structural solver, this is not possible. That part of the code is meant to solve a small system of structural equations, so it is only implemented in serial mode.

@Nicola-Fonzi Nicola-Fonzi merged commit ac042cb into su2code:develop Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiKattmann TobiKattmann TobiKattmann approved these changes

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nicola-Fonzi @TobiKattmann