Conversation
|
Currently the CGNS library embedded with SU2 does not handle parallel writing. Good idea to start a draft on this topic. |
| if(cgns_err) cg_error_print; | ||
| cgns_err = cg_zone_write(cgns_file1, base_number, zonename, *isize, Unstructured, &zone_number); | ||
|
|
||
| /*--- Write Coordinates ---*/ |
There was a problem hiding this comment.
Instead of copying the mesh data it should be nice to have the possibility to create a link to the mesh file.
cg_goto(cgns_file1, base_number, "Zone_t", zone_number, "end");
std::string path = basename + "/" + zonename + "/GridCoordinates";
cg_link_write("GridCoordinates", mesh_file.c_str(), path.c_str());
...
|
Hello @MicK7, thanks for your review.
Yes we notice that it does not handle parallel writing, so I decided to gather the data from the processes to the master node, so that only the main process writes the solution file.
Thanks for your suggestion, it would be more tidy. It is just a draft for the moment, we still have to work on it. Thank you for all the other proposed changes also, I will work on it in the next few days. |
pcarruscag
left a comment
There was a problem hiding this comment.
Nice to have this addition to the code, I don't know much about CGNS so these are maybe dumb questions:
- Will this also work to output meshes after deformation with SU2_DEF? I am guessing not because we had that issue with where to put the FFD information.
- Is it possible to write the file by sections? i.e. instead of gathering all the data in a single node do a number of Send/Recv to avoid running out of memory for large problems.
|
Hello @pcarruscag, thank you for your suggestions.
We did not think to output CGNS meshes with SU2_DEF yet. Maybe it is a development that we can consider.
I was thinking about problems with the memory. Maybe one possibility is to make each process to write a CGNS file and then merge them into one file (but I have never tried it). |
|
|
I don't know @MicK7, but for the other cgns stuff Tim Albring created a meson.build file (and for metis, parmetis, etc.) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
Proposed Changes
Hello to everyone,
my research group and I are working on the implementation of the CGNS output format.
We think that this could be an useful feature.
For the moment, in order to provide the output file in CGNS format you should choose
CGNSin theOUTPUT_FILESoption.This is a first implementation that will need some improvements.
We hope that this could be useful.
Authors: Ettore Saetta, Lorenzo Russo, Renato Tognaccini.
TAARG (Theoretical and Applied Aerodynamics Research Group), University of Naples Federico II
Related Work
PR Checklist