-
Notifications
You must be signed in to change notification settings - Fork 976
Bug in HLLC Jacobian calculation #2198
Copy link
Copy link
Closed
Labels
Description
As per the https://www.sciencedirect.com/science/article/pii/S0021999197957934 (original paper), multiplying the Jacobian with \kappa = 0.5 is not right. It is leading to non-convergence.
Further, dpStar_dU[iVar] calculations need to be relooked. As per the original paper, density should be at "j" when it is being used at "i". Though I have not seen a major difference, but currently testing the same more for strong shock cases.
Reactions are currently unavailable