Repository navigation
Fix declaration-block-no-duplicate-properties false negatives for interleaved non-consecutive duplicates with ignore: ["consecutive-duplicates(-*)"] - #9324
Conversation
…nterleaved non-consecutive duplicates
🦋 Changeset detectedLatest commit: bf602bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@sarathfrancis90 Thank you for your contribution. However, this pull request does not appear to follow our contributing guide. Please review it and update your pull request. This pull request will automatically close if there is no activity within 2 days. |
|
Thanks for the PR, but we usually request to open an issue first for such a bug, so that maintainers can triage it with correct info, e.g., a reproducible demo. Also, we'd like you to respect the PR template. It can be a bad signal. |
|
Thanks @ybiquitous, and apologies for jumping straight to a PR. I've opened #9325 with a minimal reproducible example, the config, and the expected vs. actual behavior so it can be triaged properly, and linked it here. Happy to wait for triage before this gets reviewed — and if you'd rather confirm the issue first, I'm glad to hold or close this PR and re-open once it's labeled. Whatever works best for your process. |
jeddy3
left a comment
There was a problem hiding this comment.
@sarathfrancis90 Thank you for the PR.
I've requested some changes.
Please commit them via the GitHub UI and don't force-push (see https://github.com/stylelint/stylelint/blob/main/CONTRIBUTING.md#open-a-pull-request)
declaration-block-no-duplicate-properties false negatives for interleaved non-consecutive duplicatesdeclaration-block-no-duplicate-properties false negatives for interleaved non-consecutive duplicates with ignore: ["consecutive-duplicates(-*)"]
Track the previous considered property name instead of an index for the consecutiveness check (simpler and self-documenting), mirror the comment in the fix block, bump the changeset to minor and reword it for all consecutive-duplicates(-*) options, and drop two redundant interleaved test cases.
|
Thanks for the thorough review, @jeddy3 — I've applied all eight suggestions in one follow-up commit (no force-push, per the contributing guide):
Rule tests pass locally. |
|
This PR is packaged and the instant preview is available (bf602bf). View the demo website. Install it locally: npm i -D https://pkg.pr.new/stylelint@bf602bf |
jeddy3
left a comment
There was a problem hiding this comment.
@sarathfrancis90 Thanks for making the changes. LGTM.
In the future, please apply suggestions as per the guide:
apply any suggested changes (either individually or as a batch), rather than push your own commits, so that GitHub automatically resolves the corresponding note
The CI seems to be stalling on "Verify changeset". @ybiquitous Could this be related to the changes in #9321? I believe this is the first PR from a fork since that was merged.
ybiquitous
left a comment
There was a problem hiding this comment.
Thanks, LGTM too 👍🏼
CI is now all green. ✅
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 17.12.0 | 17.13.0 | ## [v17.13.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17130---2026-06-06) It fixes 3 bugs, including a false negative one. - Fixed: `declaration-block-no-duplicate-properties` false negatives for interleaved non-consecutive duplicates with `ignore: ["consecutive-duplicates(-*)"]` ([#9324](stylelint/stylelint#9324)) ([@sarathfrancis90](https://github.com/sarathfrancis90)). - Fixed: `selector-max-type` false positives for nested selectors ([#9319](stylelint/stylelint#9319)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-type-no-unknown` false positives for `install` ([#9308](stylelint/stylelint#9308)) ([@Mouvedia](https://github.com/Mouvedia)).
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`9.39.4` -> `9.39.5`](https://renovatebot.com/diffs/npm/eslint/9.39.4/9.39.5) | | [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | devDependencies | minor | [`3.8.3` -> `3.9.10`](https://renovatebot.com/diffs/npm/prettier/3.8.3/3.9.10) | | [stylelint](https://stylelint.io) ([source](https://github.com/stylelint/stylelint)) | devDependencies | minor | [`17.12.0` -> `17.16.0`](https://renovatebot.com/diffs/npm/stylelint/17.12.0/17.16.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v9.39.5`](https://github.com/eslint/eslint/releases/tag/v9.39.5) [Compare Source](eslint/eslint@v9.39.4...v9.39.5) #### Bug Fixes - [`253be16`](eslint/eslint@253be16) fix: handle unavailable require cache (backport of [#​20812](eslint/eslint#20812) to v9.x) ([#​21065](eslint/eslint#21065)) (Eric) #### Documentation - [`74930ed`](eslint/eslint@74930ed) docs: switch build to Node.js 24 ([#​20894](eslint/eslint#20894)) (Milos Djermanovic) - [`eaec8bb`](eslint/eslint@eaec8bb) docs: Add ESLint v9.x EOL notice ([#​20828](eslint/eslint#20828)) (Milos Djermanovic) #### Chores - [`458205f`](eslint/eslint@458205f) chore: update `@eslint/eslintrc` and `@eslint/js` for v9.39.5 ([#​21077](eslint/eslint#21077)) (Francesco Trotta) - [`202117b`](eslint/eslint@202117b) chore: package.json update for [@​eslint/js](https://github.com/eslint/js) release (Jenkins) - [`d9eb6ed`](eslint/eslint@d9eb6ed) test: disable warning for `vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER` ([#​21074](eslint/eslint#21074)) (Francesco Trotta) - [`7b431a7`](eslint/eslint@7b431a7) chore: override `re2` dependency for `@metascraper/helpers` ([#​21068](eslint/eslint#21068)) (Milos Djermanovic) - [`daf7791`](eslint/eslint@daf7791) chore: pin [email protected] ([#​20895](eslint/eslint#20895)) (Milos Djermanovic) - [`daee8ba`](eslint/eslint@daee8ba) ci: use pnpm in `eslint-flat-config-utils` type integration test ([#​20829](eslint/eslint#20829)) (Milos Djermanovic) - [`116d4be`](eslint/eslint@116d4be) ci: unpin Node.js 25.x in CI ([#​20619](eslint/eslint#20619)) (Copilot) </details> <details> <summary>prettier/prettier (prettier)</summary> ### [`v3.9.10`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#3910) [Compare Source](prettier/prettier@3.9.9...3.9.10) [diff](prettier/prettier@3.9.9...3.9.10) ##### Markdown: Update `micromark-extension-gfm-table` to fix the table parse issue on performance ([#​20266](prettier/prettier#20266) by [@​fisker](https://github.com/fisker)) See micromark/micromark-extension-gfm-table@4f43ead for details. ### [`v3.9.9`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#399) [Compare Source](prettier/prettier@3.9.8...3.9.9) [diff](prettier/prettier@3.9.8...3.9.9) ##### Markdown: Fix text with `$` been incorrectly parsed as math syntax ([#​20140](prettier/prettier#20140) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```md <!-- Input --> **Uses $FOO** from `a.sh` and `b.sh`, plus `$BAR` from `c.sh`, before anything else runs here. <!-- Prettier 3.9.8 --> **Uses $FOO** from `a.sh` and `b.sh`, plus `$BAR`from`c.sh`, before anything else runs here. <!-- Prettier 3.9.9 --> **Uses $FOO** from `a.sh` and `b.sh`, plus `$BAR` from `c.sh`, before anything else runs here. ``` ### [`v3.9.8`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#398) [Compare Source](prettier/prettier@3.9.7...3.9.8) [diff](prettier/prettier@3.9.7...3.9.8) ##### Markdown: Don't let Liquid objects interrupt paragraphs ([#​20087](prettier/prettier#20087) by [@​seiyab](https://github.com/seiyab)) <!-- prettier-ignore --> ```markdown <!-- Input --> If `module` is not a [`WebAssembly.Module`](/en-US/docs/WebAssembly/Reference/JavaScript_interface/Module) object instance, a {{jsxref("TypeError")}} is thrown. <!-- Prettier 3.9.7 --> If `module` is not a [`WebAssembly.Module`](/en-US/docs/WebAssembly/Reference/JavaScript_interface/Module) object instance, a {{jsxref("TypeError")}} is thrown. <!-- Prettier 3.9.8 --> If `module` is not a [`WebAssembly.Module`](/en-US/docs/WebAssembly/Reference/JavaScript_interface/Module) object instance, a {{jsxref("TypeError")}} is thrown. ``` ### [`v3.9.7`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#397) [Compare Source](prettier/prettier@3.9.6...3.9.7) [diff](prettier/prettier@3.9.6...3.9.7) ##### Markdown: Prevent indentation drift in list-item code blocks ([#​19647](prettier/prettier#19647), [#​19990](prettier/prettier#19990) by [@​Austin1serb](https://github.com/Austin1serb), [@​giaBaoJS](https://github.com/giaBaoJS)) <!-- prettier-ignore --> ```markdown <!-- Input --> - [x] short first line. second paragraph at six spaces that wraps onto another line here. <!-- Prettier 3.9.6 --> - [x] short first line. second paragraph at six spaces that wraps onto another line here. <!-- Prettier 3.9.7 --> - [x] short first line. second paragraph at six spaces that wraps onto another line here. ``` ##### JavaScript: Fix embedded template literal idempotency ([#​19725](prettier/prettier#19725) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```jsx // Input const foo = html` <div>${getText({ value, })}</div> `; // Prettier 3.9.6 (first format) const foo = html` <div> ${getText({ value, })} </div> `; // Prettier 3.9.6 (second format) const foo = html` <div> ${getText({ value, })} </div> `; // Prettier 3.9.7 const foo = html` <div> ${getText({ value, })} </div> `; ``` ##### Markdown: Preserve Liquid blocks after Markdown tables ([#​19730](prettier/prettier#19730) by [@​wanxiankai](https://github.com/wanxiankai), [@​seiyab](https://github.com/seiyab)) <!-- prettier-ignore --> ```markdown <!-- Input --> | Argument | Type | | -------- | ---- | {% set default_params = { "model": ["str"], } %} <!-- Prettier 3.9.6 --> | Argument | Type | | ------------------------- | ---- | | {% set default_params = { | "model": ["str"], } %} <!-- Prettier 3.9.7 --> | Argument | Type | | -------- | ---- | {% set default_params = { "model": ["str"], } %} ``` ##### Markdown: Preserve single tildes in Markdown ([#​19739](prettier/prettier#19739) by [@​lazerg](https://github.com/lazerg)) Since 3.9.0, single-tilde spans like `H~2~O` were rewritten to double tildes, turning subscript syntax into strike-through. Only double tildes are treated that way now, matching GitHub. <!-- prettier-ignore --> ```markdown <!-- Input --> H~2~O <!-- Prettier 3.9.6 --> H~~2~~O <!-- Prettier 3.9.7 --> H~2~O ``` ##### Markdown: Fix Markdown blockquote containing `>` characters ([#​19802](prettier/prettier#19802) by [@​seiyab](https://github.com/seiyab)) <!-- prettier-ignore --> ```md <!-- Input --> > **test**\> <!-- Prettier 3.9.6 --> > **test**>\> <!-- Prettier 3.9.7 --> > **test**\> ``` ##### Markdown: Strip blockquote markers from a setext heading's continuation lines ([#​19878](prettier/prettier#19878) by [@​Kjubikstronk](https://github.com/Kjubikstronk)) A setext heading spanning multiple lines inside a blockquote kept the `>` marker of its continuation lines as literal text. <!-- prettier-ignore --> ```md <!-- Input --> > Multi > Line > === <!-- Prettier 3.9.6 --> > Multi > Line > === <!-- Prettier 3.9.7 --> > Multi > Line > === ``` ##### Markdown: Fix HTML block indentation drift in markdown list items ([#​19987](prettier/prettier#19987) by [@​lazerg](https://github.com/lazerg)) <!-- prettier-ignore --> ```markdown <!-- Input --> 1. Enable images: <p align="center"> <img alt="example"> </p> <!-- Prettier 3.9.6 (--tab-width=4) --> 1. Enable images: <p align="center"> <img alt="example"> </p> <!-- Prettier 3.9.7 (--tab-width=4) --> 1. Enable images: <p align="center"> <img alt="example"> </p> ``` ##### Angular: Support `@boundary` error boundaries ([#​20014](prettier/prettier#20014) by [@​Yahiro025](https://github.com/Yahiro025)) <!-- prettier-ignore --> ```html <!-- Input --> @​boundary { <complex-chart [data]="data"/> } @​error (let err) { <p>{{err.message}}</p> } <!-- Prettier 3.9.6 --> SyntaxError: Unexpected character "EOF" (Do you have an unescaped "{" in your template? Use "{{ '{' }}") to escape it.) (6:1) <!-- Prettier 3.9.7 --> @​boundary { <complex-chart [data]="data" /> } @​error (let err) { <p>{{ err.message }}</p> } ``` ### [`v3.9.6`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#396) [Compare Source](prettier/prettier@3.9.5...3.9.6) [diff](prettier/prettier@3.9.5...3.9.6) ##### TypeScript: Preserve quotes for methods named `new` ([#​19621](prettier/prettier#19621) by [@​kovsu](https://github.com/kovsu)) <!-- prettier-ignore --> ```tsx // Input interface Container { "new"(id: string): number; } // Prettier 3.9.5 interface Container { new(id: string): number; } // Prettier 3.9.6 interface Container { "new"(id: string): number; } ``` ##### TypeScript: Support `import defer` ([#​19624](prettier/prettier#19624), [#​19675](prettier/prettier#19675) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```tsx // Input import defer * as foo from "foo"; // Prettier 3.9.5 import * as foo from "foo"; // Prettier 3.9.6 import defer * as foo from "foo"; ``` ##### JavaScript: Added a new official plugin `@prettier/plugin-yuku` ([#​19628](prettier/prettier#19628), [#​19629](prettier/prettier#19629) by [@​fisker](https://github.com/fisker)) `@prettier/plugin-yuku` is powered by [Yuku](https://yuku.fyi/) (A high-performance JavaScript/TypeScript compiler toolchain written in Zig). This plugin includes two new parsers: `yuku` (JavaScript syntax) and `yuku-ts` (TypeScript syntax). **To use this plugin:** 1. Install the plugin: ```bash yarn add --dev prettier @​prettier/plugin-yuku ``` 2. Add it to your `.prettierrc`: ```yaml plugins: - "@​prettier/plugin-yuku" ``` Due to package size limitations, this plugin is not bundled with the main prettier package and must be installed separately. For more information, check [the package homepage](https://github.com/prettier/prettier/tree/main/packages/plugin-yuku). Big thanks to [@​arshad-yaseen](https://github.com/arshad-yaseen) for his excellent work. ### [`v3.9.5`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#395) [Compare Source](prettier/prettier@3.9.4...3.9.5) [diff](prettier/prettier@3.9.4...3.9.5) ##### Markdown: Cap ordered list mark at 999,999,999 ([#​19351](prettier/prettier#19351) by [@​tats-u](https://github.com/tats-u)) CommonMark parsers only support ordered list item numbers up to 999,999,999. With this change, Prettier now caps the ordered list item number at 999,999,999 to ensure that the output is correctly parsed as an ordered list by CommonMark parsers. Numbers larger than 999,999,999 are not parsed as list item numbers and are left unchanged in the output: <!-- prettier-ignore --> ```markdown <!-- Input --> 999999998. text 999999998. text 999999998. text 999999998. text 1234567890123456789012) text <!-- Prettier 3.9.4 --> 999999998. text 999999999. text 1000000000. text 1000000001. text 1234567890123456789012) text <!-- Prettier 3.9.5 --> 999999998. text 999999999. text 999999999. text 999999999. text 1234567890123456789012) text ``` ##### Markdown: Avoid corrupting empty link with title ([#​19487](prettier/prettier#19487) by [@​andersk](https://github.com/andersk)) Do not remove `<>` from an inline link or image with an empty URL and a title, as this removal would change its interpretation. <!-- prettier-ignore --> ```md <!-- Input --> [link](<> "title") <!-- Prettier 3.9.4 --> [link]( "title") <!-- Prettier 3.9.5 --> [link](<> "title") ``` ##### Less: Remove extra spaces after `[` in map lookups ([#​19503](prettier/prettier#19503) by [@​kovsu](https://github.com/kovsu)) <!-- prettier-ignore --> ```less // Input .foo { color: #theme[ primary]; color: #theme[@​name]; color: #theme[@​@​name]; } // Prettier 3.9.4 .foo { color: #theme[ primary]; color: #theme[ @​name]; color: #theme[ @​@​name]; } // Prettier 3.9.5 .foo { color: #theme[primary]; color: #theme[@​name]; color: #theme[@​@​name]; } ``` ##### CSS: Prevent addition space in `type()` with `+` ([#​19516](prettier/prettier#19516) by [@​bigandy](https://github.com/bigandy)) This fixes the addition space before `+` in CSS `type()` declaration. For example `type(<number>+)` was being converted into `type(<number> +)` which is invalid CSS and does not work. <!-- prettier-ignore --> ```css /* Input */ div { border-radius: attr(br type(<length>+)); } /* Prettier 3.9.4 */ div { border-radius: attr(br type(<length> +)); } /* Prettier 3.9.5 */ div { border-radius: attr(br type(<length>+)); } ``` ##### Less: Remove spaces between merge markers and colons ([#​19517](prettier/prettier#19517) by [@​kovsu](https://github.com/kovsu)) <!-- prettier-ignore --> ```less // Input a { box-shadow + : 0 0 1px #​000; } // Prettier 3.9.4 a { box-shadow+ : 0 0 1px #​000; } // Prettier 3.9.5 a { box-shadow+: 0 0 1px #​000; } ``` ##### Markdown: Preserve wiki links with aliases ([#​19527](prettier/prettier#19527) by [@​kovsu](https://github.com/kovsu)) <!-- prettier-ignore --> ```markdown <!-- Input --> [[Foo:Bar]] <!-- Prettier 3.9.4 --> [[Foo]] <!-- Prettier 3.9.5 --> [[Foo:Bar]] ``` ##### TypeScript: Fix comments being dropped on shorthand `type` import/export specifiers ([#​19565](prettier/prettier#19565) by [@​kirkwaiblinger](https://github.com/kirkwaiblinger)) <!-- prettier-ignore --> ```tsx // Input export { type /* comment */ T } from "foo"; import { type /* comment */ T } from "foo"; // Prettier 3.9.4 Error: Comment "comment" was not printed. Please report this error! // Prettier 3.9.5 export { type /* comment */ T } from "foo"; import { type /* comment */ T } from "foo"; ``` ##### Miscellaneous: Preserving comments' `placement` property ([#​19567](prettier/prettier#19567) by [@​Janther](https://github.com/Janther)) [email protected] deleted an undocumented property on comments, which was already used by plugins, `comment.placement` is now available again after comment attach. ##### Flow: Stop enforcing empty module declaration to break ([#​19568](prettier/prettier#19568) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```flow // Input declare module "foo" {} // Prettier 3.9.4 declare module "foo" { } // Prettier 3.9.5 declare module "foo" {} ``` ##### Angular: Support expression for exhaustive typechecking ([#​19571](prettier/prettier#19571) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```html <!-- Input --> @​switch (state.mode) { @​default never(state); } <!-- Prettier 3.9.4 --> @​switch (state.mode) { @​default never; } <!-- Prettier 3.9.5 --> @​switch (state.mode) { @​default never(state); } ``` ##### TypeScript: Ignore comments inside mapped type when checking type parameter comments ([#​19572](prettier/prettier#19572) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```tsx // Input foo<{ // comment [key in keyof Foo]: number }>(); // Prettier 3.9.4 foo< { // comment [key in keyof Foo]: number; } >(); // Prettier 3.9.5 foo<{ // comment [key in keyof Foo]: number; }>(); ``` ##### Less: Fix adjacent block comments being corrupted ([#​19574](prettier/prettier#19574) by [@​kovsu](https://github.com/kovsu)) <!-- prettier-ignore --> ```less // Input /* a *//* b */ /* a */* { color: red; } // Prettier 3.9.4 /* a */ /* b */ /* a * { color: red; } // Prettier 3.9.5 /* a */ /* b */ /* a */ * { color: red; } ``` ##### JavaScript: Handle dangling comments in `SwitchStatement` ([#​19581](prettier/prettier#19581) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```jsx // Input switch (foo) { // comment } // Prettier 3.9.4 switch ( foo // comment ) { } // Prettier 3.9.5 switch (foo) { // comment } ``` ##### TypeScript: Remove space in comment-only object type ([#​19583](prettier/prettier#19583) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```tsx // Input var foo = { /* comment */ }; type Foo = { /* comment */ }; // Prettier 3.9.4 var foo = {/* comment */}; type Foo = { /* comment */ }; // Prettier 3.9.5 var foo = {/* comment */}; type Foo = {/* comment */}; ``` ### [`v3.9.4`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#394) [Compare Source](prettier/prettier@3.9.3...3.9.4) [diff](prettier/prettier@3.9.3...3.9.4) ##### Angular: Format `@content(name)` -> `@content (name)` to align with other block syntax ([#​19499](prettier/prettier#19499) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```html <!-- Input --> <FancyButton [label]="title"> @​content (icon) { <span>Icon!</span> } @​content (description) { <span>Description text</span> } <span>Other children</span> </FancyButton> <!-- Prettier 3.9.3 --> <FancyButton [label]="title"> @​content(icon) { <span>Icon!</span> } @​content(description) { <span>Description text</span> } <span>Other children</span> </FancyButton> <!-- Prettier 3.9.4 --> <FancyButton [label]="title"> @​content (icon) { <span>Icon!</span> } @​content (description) { <span>Description text</span> } <span>Other children</span> </FancyButton> ``` ### [`v3.9.3`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#393) [Compare Source](prettier/prettier@3.9.2...3.9.3) [diff](prettier/prettier@3.9.1...3.9.3) ##### Markdown: Fix unexpected removal of characters in liquid syntax ([#​19489](prettier/prettier#19489) by [@​seiyab](https://github.com/seiyab)) <!-- prettier-ignore --> ```md // Input <!-- Input --> {{ page.title }} text <!-- Prettier 3.9.1 --> {{ page.title text <!-- Prettier 3.9.3 --> {{ page.title }} text ``` ##### TypeScript: Allow decorators to be used with declare on class fields ([#​19492](prettier/prettier#19492) by [@​evoactivity](https://github.com/evoactivity)) Extensively used within the Ember ecosystem, decorators with `declare` on class fields will ignore the babel parser error and allow Prettier to format the code without breaking it. <!-- prettier-ignore --> ```ts // Input export default class ProjectStatusComponent extends Component<ProjectStatusSig> { @​service declare server: ServerService; } // Prettier 3.9.1 // SyntaxError: Decorators can't be used with a declare field. (2:3) // 1 | export default class ProjectStatusComponent extends Component<ProjectStatusSig> { //> 2 | @​service declare server: ServerService; // | ^ // 3 | } // Prettier 3.9.3 export default class ProjectStatusComponent extends Component<ProjectStatusSig> { @​service declare server: ServerService; } ``` ### [`v3.9.2`](prettier/prettier@3.9.1...3.9.2) [Compare Source](prettier/prettier@3.9.1...3.9.2) ### [`v3.9.1`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#3910) [Compare Source](prettier/prettier@3.9.0...3.9.1) [diff](prettier/prettier@3.9.9...3.9.10) ##### Markdown: Update `micromark-extension-gfm-table` to fix the table parse issue on performance ([#​20266](prettier/prettier#20266) by [@​fisker](https://github.com/fisker)) See micromark/micromark-extension-gfm-table@4f43ead for details. ### [`v3.9.0`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#390) [Compare Source](prettier/prettier@3.8.5...3.9.0) [diff](prettier/prettier@3.8.5...3.9.0) 🔗 [Release Notes](https://prettier.io/blog/2026/06/27/3.9.0) ### [`v3.8.5`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#385) [Compare Source](prettier/prettier@3.8.4...3.8.5) [diff](prettier/prettier@3.8.4...3.8.5) ##### Flow: Support `readonly` as a variance annotation ([#​19022](prettier/prettier#19022) by [@​marcoww6](https://github.com/marcoww6)) Flow now accepts `readonly` as a property variance annotation, equivalent to `+` (covariant/read-only). <!-- prettier-ignore --> ```jsx // Input type T = { readonly foo: string, }; // Prettier 3.8.4 SyntaxError // Prettier 3.8.5 type T = { readonly foo: string, }; ``` ### [`v3.8.4`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#384) [Compare Source](prettier/prettier@3.8.3...3.8.4) [diff](prettier/prettier@3.8.3...3.8.4) ##### Markdown: Fix blank lines between list items and nested sub-lists being removed in Markdown/MDX ([#​17746](prettier/prettier#17746) by [@​byplayer](https://github.com/byplayer)) Prettier was removing blank lines between list items and their nested sub-lists, converting loose lists into tight lists and changing their semantic meaning. <!-- prettier-ignore --> ```markdown <!-- Input --> - a - b - c - d <!-- Prettier 3.8.3 --> - a - b - c - d <!-- Prettier 3.8.4 --> - a - b - c - d ``` </details> <details> <summary>stylelint/stylelint (stylelint)</summary> ### [`v17.16.0`](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17160---2026-10-01) [Compare Source](stylelint/stylelint@17.15.0...17.16.0) It fixes 2 bugs in the `layout-mappings` rules. This will likely be the last `17.x` release, as we prepare for `18.0.0`. - Fixed: `property-layout-mappings` and `unit-layout-mappings` false negatives for uppercase property names and units ([#​9485](stylelint/stylelint#9485)) ([@​giaBaoJS](https://github.com/giaBaoJS)). - Fixed: `value-keyword-layout-mappings` false positives for `caption-side` ([#​9483](stylelint/stylelint#9483)) ([@​giaBaoJS](https://github.com/giaBaoJS)). ### [`v17.15.0`](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17150---2026-09-04) [Compare Source](stylelint/stylelint@17.14.1...17.15.0) It adds 1 new rule and 2 new rule options, and fixes 4 bugs. - Added: `selector-no-unmatchable` rule ([#​9451](stylelint/stylelint#9451)) ([@​jeddy3](https://github.com/jeddy3)). - Added: `ignoreFunctions: []` to `color-named` and `color-no-hex` ([#​9463](stylelint/stylelint#9463)) ([@​jsmitty12](https://github.com/jsmitty12)). - Fixed: `custom-property-no-missing-var-function` false positives for anchor positioning ([#​9466](stylelint/stylelint#9466)) ([@​giaBaoJS](https://github.com/giaBaoJS)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix for `font` shorthand ([#​9402](stylelint/stylelint#9402)) ([@​sarathfrancis90](https://github.com/sarathfrancis90)). - Fixed: `declaration-property-max-values` false positives for interpolated inline expressions ([#​9437](stylelint/stylelint#9437)) ([@​alexchen-sys](https://github.com/alexchen-sys)). - Fixed: `selector-no-invalid` false negatives for pseudo-elements, combinators and nested `:has()` ([#​9452](stylelint/stylelint#9452)) ([@​jeddy3](https://github.com/jeddy3)). ### [`v17.14.1`](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17141---2026-07-20) [Compare Source](stylelint/stylelint@17.14.0...17.14.1) It fixes 4 bugs. - Fixed: `quiet` option suppresses `report*` warning reports ([#​9387](stylelint/stylelint#9387)) ([@​ychampion](https://github.com/ychampion)). - Fixed: reported range of unknown rules ([#​9385](stylelint/stylelint#9385)) ([@​ybiquitous](https://github.com/ybiquitous)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix producing invalid `background` shorthand when `background-size` is present ([#​9364](stylelint/stylelint#9364)) ([@​sarathfrancis90](https://github.com/sarathfrancis90)). - Fixed: `rule-empty-line-before` false positives for shared-line comments with `except: ["after-single-line-comment"]` ([#​9394](stylelint/stylelint#9394)) ([@​sarathfrancis90](https://github.com/sarathfrancis90)). ### [`v17.14.0`](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17140---2026-06-25) [Compare Source](stylelint/stylelint@17.13.0...17.14.0) It fixes 3 bugs, including a false negative one. - Fixed: performance of getting module paths ([#​9354](stylelint/stylelint#9354)) ([@​jeddy3](https://github.com/jeddy3)). - Fixed: performance by dynamically importing `TIMING` only on use ([#​9356](stylelint/stylelint#9356)) ([@​jeddy3](https://github.com/jeddy3)). - Fixed: `function-calc-no-unspaced-operator` false negatives for unspaced `+` and `-` operators following a `*` or `/` operator ([#​9357](stylelint/stylelint#9357)) ([@​sarathfrancis90](https://github.com/sarathfrancis90)). ### [`v17.13.0`](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#17130---2026-06-06) [Compare Source](stylelint/stylelint@17.12.0...17.13.0) It fixes 3 bugs, including a false negative one. - Fixed: `declaration-block-no-duplicate-properties` false negatives for interleaved non-consecutive duplicates with `ignore: ["consecutive-duplicates(-*)"]` ([#​9324](stylelint/stylelint#9324)) ([@​sarathfrancis90](https://github.com/sarathfrancis90)). - Fixed: `selector-max-type` false positives for nested selectors ([#​9319](stylelint/stylelint#9319)) ([@​romainmenke](https://github.com/romainmenke)). - Fixed: `selector-type-no-unknown` false positives for `install` ([#​9308](stylelint/stylelint#9308)) ([@​Mouvedia](https://github.com/Mouvedia)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4wIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.robbevp.be/robbevp/website-robbevanpetegem/pulls/511
Which issue, if any, is this issue related to?
Reported in #9325 (with a minimal reproducible example).
Is there anything in the PR that needs further explanation?
The problem
With
ignore: ["consecutive-duplicates"](and the relatedconsecutive-duplicates-with-different-syntaxes/consecutive-duplicates-with-same-prefixless-valuesoptions), the rule is meant to report only non-consecutive duplicate properties. When two different properties are interleaved, a non-consecutive duplicate of one of them is missed, and autofix is non-idempotent.For example, with
ignore: ["consecutive-duplicates"]:Only the duplicate
coloris reported; the duplicatebackgroundis missed even though both are genuine non-consecutive duplicates. As a result--fixdoes not converge in a single pass:a { background: white; color: blue; background: black; }a { color: blue; background: black; }This contradicts the rule's documentation, which lists non-consecutive duplicates of the same property as problems.
Root cause
Consecutiveness was inferred with the proxy:
declstracks the "active" declaration per property. When two distinct properties are interleaved, the duplicated property is no longer the last element ofdecls, soindexDuplicate === decls.length - 1isfalsefor a duplicate that is in fact a problem to report — but the surrounding logic then mishandled it, dropping the second property's duplicate and breaking single-pass idempotency.The fix
Track the index of the previously considered declaration explicitly and treat a duplicate as consecutive only when the previously considered declaration is its own previous occurrence:
The active declaration in
declsis also updated when the earlier duplicate is removed, so later duplicates compare against the correct kept declaration. The patched rule now reports bothcolorandbackground, and--fixconverges in a single pass.Did you add or update tests?
Yes. Added reject cases for interleaved properties with non-consecutive duplicates under both
ignore: ["consecutive-duplicates"]andignore: ["consecutive-duplicates-with-different-syntaxes"], asserting both warnings and the fixed (idempotent) output. These tests fail onmainand pass with the fix. The full Jest suite,tsc, ESLint, Prettier, and remark all pass locally.Have you successfully run tests with your changes locally?
Yes.