Skip to content

Add alpha-value-notation support for computing EditInfo #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romainmenke merged 2 commits into from
Feb 26, 2025
Merged

Add alpha-value-notation support for computing EditInfo #8369

romainmenke merged 2 commits into from
Feb 26, 2025
+262 −4

Conversation

@pamelalozano16
Copy link
Contributor

@pamelalozano16 pamelalozano16 commented Jan 30, 2025

Which issue, if any, is this issue related to?

See: #8362

Is there anything in the PR that needs further explanation?

I added some cases with multiple warnings in fix: true to make sure the semicolon after declarations wasn't being removed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b01e52c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pamelalozano16 pamelalozano16 changed the title Add alpha-value-notation support for EditInfo Add alpha-value-notation support for EditInfo. Jan 30, 2025
@pamelalozano16 pamelalozano16 mentioned this pull request Jan 31, 2025
Merged
@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch from 0678750 to f4eb93e Compare January 31, 2025 00:48
@ybiquitous ybiquitous changed the title Add alpha-value-notation support for EditInfo. Add alpha-value-notation support for EditInfo Jan 31, 2025
@ybiquitous ybiquitous mentioned this pull request Jan 31, 2025
Closed
35 tasks
ybiquitous
ybiquitous previously requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pamelalozano16 Thank you for the pull request and adding many test cases for better coverage. 👍🏼

I've left a few comments on the maintenance, can you have a look? Thanks.

@ybiquitous ybiquitous changed the title Add alpha-value-notation support for EditInfo Add alpha-value-notation support for computing EditInfo Jan 31, 2025
@ybiquitous
Copy link
Member

ybiquitous commented Jan 31, 2025

@pamelalozano16 I updated the PR title to match #8363. In addition, can you add a minor changelog item like #8363?

stylelint/.changeset/nine-needles-grow.md

Lines 1 to 5 in 86d2c17

---
"stylelint": minor
---
Added: `declaration-block-no-duplicate-properties` support for computing `EditInfo`

@Mouvedia Mouvedia added the pr: blocked is blocked by another issue or pr label Jan 31, 2025
@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch 2 times, most recently from 0695e5d to 3df6e2b Compare January 31, 2025 19:36
Mouvedia
Mouvedia reviewed Feb 2, 2025
View reviewed changes
Mouvedia
Mouvedia reviewed Feb 2, 2025
View reviewed changes
@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch 3 times, most recently from e05e3ff to 877c360 Compare February 5, 2025 19:19
@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch from 877c360 to 9587ff5 Compare February 19, 2025 21:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025 •
edited
Loading

Try the Instant Preview in Online Demo

Stylelint Online Demo

Install the Instant Preview to Your Local

npm i -D https://pkg.pr.new/stylelint@8369

View Commit

@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch from 6e5a497 to b24a7b2 Compare February 25, 2025 18:41
@Mouvedia Mouvedia removed the pr: blocked is blocked by another issue or pr label Feb 25, 2025
Mouvedia
Mouvedia reviewed Feb 25, 2025
View reviewed changes
Mouvedia
Mouvedia approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart for the missing fix object this LGTM.

@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch 2 times, most recently from 807153d to 6dae9f8 Compare February 26, 2025 00:35
romainmenke
romainmenke reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions to simplify the test cases.
I think those will also work fine.

@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch from 6dae9f8 to 0e0574c Compare February 26, 2025 18:55
@pamelalozano16 pamelalozano16 force-pushed the add-support-alpha-value-notation branch from 0e0574c to b01e52c Compare February 26, 2025 18:56
romainmenke
romainmenke approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍

@romainmenke romainmenke dismissed ybiquitous’s stale review February 26, 2025 21:53

Feedback was resolved

@romainmenke romainmenke merged commit eec62e5 into stylelint:main Feb 26, 2025
19 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 1, 2025
@renovate
Update dependency stylelint to v16.15.0
7c710b3 
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.14.0 | 16.15.0 |


## [v16.15.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16150---2025-02-28)

It adds 1 new rule, a `languageOptions` configuration property for configuring some of the new rules added in `16.13.0`, regex support to 1 option and support for computing `EditInfo` to 6 rules. It fixes 9 bugs, including 2 with the `tap` reporter.

-   Added: `syntax-string-no-invalid` rule ([#8331](stylelint/stylelint#8331)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `languageOptions` configuration property ([#8297](stylelint/stylelint#8297)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: regex support to `ignoreAtRules` option of `at-rule-empty-line-before` ([#8385](stylelint/stylelint#8385)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `alpha-value-notation` support for computing `EditInfo` ([#8369](stylelint/stylelint#8369)) ([@pamelalozano16](https://github.com/pamelalozano16)).
-   Added: `color-hex-length` support for computing `EditInfo` ([#8415](stylelint/stylelint#8415)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `comment-empty-line-before` support for computing `EditInfo` ([#8416](stylelint/stylelint#8416)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `comment-whitespace-inside` support for computing `EditInfo` ([#8417](stylelint/stylelint#8417)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `custom-property-empty-line-before` support for computing `EditInfo` ([#8418](stylelint/stylelint#8418)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `declaration-block-no-duplicate-properties` support for computing `EditInfo` ([#8363](stylelint/stylelint#8363)) ([@romainmenke](https://github.com/romainmenke)).
-   Fixed: `tap` formatter not escaping `#` and `\` in its test point descriptions ([#8334](stylelint/stylelint#8334)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `tap` formatter outputting invalid YAML blocks for rules containing double quotes in their warnings' messages ([#8334](stylelint/stylelint#8334)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-block-no-redundant-longhand-properties` false positives for properties with `!important` ([#8366](stylelint/stylelint#8366)) ([@immitsu](https://github.com/immitsu)).
-   Fixed: `EditInfo` missing semicolon in `text` field ([#8370](stylelint/stylelint#8370)) ([@pamelalozano16](https://github.com/pamelalozano16)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` false negatives for `text-decoration: blink` ([#8351](stylelint/stylelint#8351)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` false positives for styled components interpolated functions ([#8392](stylelint/stylelint#8392)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `font-family-name-quotes` false positives due to vendor-prefixed font-size values ([#8393](stylelint/stylelint#8393)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `font-family-no-missing-generic-family-keyword` false positives for `math`, `emoji` and `fangsong` ([#8395](stylelint/stylelint#8395)) ([@ViachaslauIhnatsiuk](https://github.com/ViachaslauIhnatsiuk)).
-   Fixed: `selector-type-no-unknown` false positives for `selectmenu` and `popup` ([#8376](stylelint/stylelint#8376)) ([@Mouvedia](https://github.com/Mouvedia)).


## [v16.14.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16141---2025-01-27)

It fixes a bug with caching.

-   Fixed: incompatible cache file format ([#8359](stylelint/stylelint#8359)) ([@romainmenke](https://github.com/romainmenke)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mouvedia Mouvedia Mouvedia approved these changes

@romainmenke romainmenke romainmenke approved these changes

@ybiquitous ybiquitous Awaiting requested review from ybiquitous

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pamelalozano16 @ybiquitous @Mouvedia @romainmenke