Skip to content

Conversation

@romainmenke
Copy link
Member

Which issue, if any, is this issue related to?

Closes #8304

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 805b552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mister-Hope
Copy link

Mister-Hope commented Jan 13, 2025

It would be great to have this fixed and releases ASAP, as overriding ignore to 7.0.0 now will make users project break again once this PR is merged and a new version of stylelint is released.

Edited: I believe it's better to pin the ignore to 7.0.0 instead of applying 7.0.1 change, it's ignore that is not following semver and it will possibly reverting the previous behavior in next patch and raise another major.

@romainmenke
Copy link
Member Author

It would be great to have this fixed and releases ASAP, as overriding ignore to 7.0.0 now will make users project break again once this PR is merged and a new version of stylelint is released.

Edited: I believe it's better to pin the ignore to 7.0.0 instead of applying 7.0.1 change, it's ignore that is not following semver and it will possibly reverting the previous behavior in next patch and raise another major.

See the two commits I made :)

I am anticipating a potential upstream revert and made sure that both versions work with the changes here in Stylelint.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am anticipating a potential upstream revert and made sure that both versions work with the changes here in Stylelint.

Nicely done.

I think I've enough time to do a release. We may as well release to minimise the length of disruption to our users, regardless of what action is taken upstream.

@jeddy3 jeddy3 merged commit 7ea4219 into main Jan 13, 2025
17 checks passed
@jeddy3 jeddy3 deleted the fix-ignore--practical-banded-palm-civet-03392d41e3 branch January 13, 2025 17:59
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 17, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.13.0 | 16.13.2 |


## [v16.13.2](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16132---2025-01-14)

It fixes a regression bug with `--fix`.

-   Fixed: `--fix` CLI flag raising unknown value error ([#8313](stylelint/stylelint#8313)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.13.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16131---2025-01-13)

It fixes one bug due to an upstream change in our `ignore` dependency.

-   Fixed: `ignore.default is not a function` ([#8305](stylelint/stylelint#8305)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 20, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.13.0 | 16.13.2 |


## [v16.13.2](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16132---2025-01-14)

It fixes a regression bug with `--fix`.

-   Fixed: `--fix` CLI flag raising unknown value error ([#8313](stylelint/stylelint#8313)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.13.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16131---2025-01-13)

It fixes one bug due to an upstream change in our `ignore` dependency.

-   Fixed: `ignore.default is not a function` ([#8305](stylelint/stylelint#8305)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 24, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.13.0 | 16.13.2 |


## [v16.13.2](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16132---2025-01-14)

It fixes a regression bug with `--fix`.

-   Fixed: `--fix` CLI flag raising unknown value error ([#8313](stylelint/stylelint#8313)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.13.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16131---2025-01-13)

It fixes one bug due to an upstream change in our `ignore` dependency.

-   Fixed: `ignore.default is not a function` ([#8305](stylelint/stylelint#8305)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 25, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.13.0 | 16.13.2 |


## [v16.13.2](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16132---2025-01-14)

It fixes a regression bug with `--fix`.

-   Fixed: `--fix` CLI flag raising unknown value error ([#8313](stylelint/stylelint#8313)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.13.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16131---2025-01-13)

It fixes one bug due to an upstream change in our `ignore` dependency.

-   Fixed: `ignore.default is not a function` ([#8305](stylelint/stylelint#8305)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 26, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.13.0 | 16.14.0 |


## [v16.14.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16140---2025-01-25)

It fixes 8 bugs and adds features to our `Warning` type.

-   Added: replaced text and corresponding range to `Warning` type ([#8234](stylelint/stylelint#8234)) ([@romainmenke](https://github.com/romainmenke)).
-   Fixed: `SyntaxError: The requested module 'table'...` ([#8325](stylelint/stylelint#8325)) ([@denisx](https://github.com/denisx)).
-   Fixed: `RuleContext['fix']` type ([#8309](stylelint/stylelint#8309)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` autofix of `border-color` and `overflow` ([#8346](stylelint/stylelint#8346)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` false negatives for `overflow-x` and `overflow-y` ([#8340](stylelint/stylelint#8340)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` false negatives for `scrollbar-color` ([#8346](stylelint/stylelint#8346)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` false positives for non-standard syntax values ([#8329](stylelint/stylelint#8329)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `declaration-property-value-keyword-no-deprecated` warning message for `overflow: <keyword> <keyword>` ([#8340](stylelint/stylelint#8340)) ([@Mouvedia](https://github.com/Mouvedia)).
-   Fixed: `selector-pseudo-class-no-unknown` false positives for `:has-slotted` ([#8332](stylelint/stylelint#8332)) ([@Mouvedia](https://github.com/Mouvedia)).


## [v16.13.2](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16132---2025-01-14)

It fixes a regression bug with `--fix`.

-   Fixed: `--fix` CLI flag raising unknown value error ([#8313](stylelint/stylelint#8313)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.13.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16131---2025-01-13)

It fixes one bug due to an upstream change in our `ignore` dependency.

-   Fixed: `ignore.default is not a function` ([#8305](stylelint/stylelint#8305)) ([@romainmenke](https://github.com/romainmenke)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix ignore.default is not a function

4 participants