Add `declaration-property-value-keyword-no-deprecated` #8223

Mouvedia · 2024-12-24T17:48:43Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

I went for a simple implementation.

i.e.

not trying to fix the word-break: break-word; case

shorthand properties are not supported
e.g. background: no-repeat border-box InactiveBorder;

intrinsic and min-intrinsic don't get a fix because it would require a lot of research to confirm that the standard-compliant keywords are truly equivalent in every aspect
i.e. it's unsafe

This PR also remove some duplicated keywords from systemColorsKeywords.

changeset-bot · 2024-12-24T17:48:48Z

🦋 Changeset detected

Latest commit: c3a1667

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mouvedia · 2024-12-24T18:34:51Z

lib/reference/properties.mjs

 	],
 ]);

+export const singleValueColorProperties = new Set([


scrollbar-color accept 2 colors

Mouvedia · 2024-12-24T19:45:21Z

docs/user-guide/rules.md

+### Deprecated
+
+Disallow deprecated things with these `no-deprecated` rules.


Mouvedia · 2024-12-24T19:47:44Z

lib/rules/declaration-property-value-no-deprecated/index.mjs

+const NAME_TO_VALUE = new Map([
+	[
+		'appearance',
+		/** @type {string | string[] | Record<string, string>} */ ({


typescript uses the first value to infer the type of the values
i.e. Map<string, string | string[] | Record<string, string>> errors out

Mouvedia · 2024-12-24T19:56:44Z

lib/rules/declaration-property-value-no-deprecated/index.mjs

+	['min-height', ['intrinsic', 'min-intrinsic']],
+	['min-width', ['intrinsic', 'min-intrinsic']],
+	['max-height', ['intrinsic', 'min-intrinsic']],
+	['max-width', ['intrinsic', 'min-intrinsic']],
+	['height', ['intrinsic', 'min-intrinsic']],
+	['width', ['intrinsic', 'min-intrinsic']],


Supporting arrays as keys for the map would be too impractical.
i.e.

[ ['min-height', 'min-width', 'max-height', 'max-width', 'height', 'width'], ['intrinsic', 'min-intrinsic'] ],

Mouvedia · 2024-12-24T20:31:38Z

docs/user-guide/rules.md

+<!-- prettier-ignore-start -->
+| | | |
+| :-- | :-: | :-: |
+| [`declaration-property-value-no-deprecated`](../../lib/rules/declaration-property-value-no-deprecated/README.md)<br/>Disallow deprecated values for properties within declarations. | | 🔧 |


I left it empty because I can't guarantee that it will part of the next stylelint-config-standard release.

jeddy3

@Mouvedia Thank you for working on this rule, especially digging into the mappings between deprecated and new keywords! It's looking good.

lib/rules/declaration-property-value-keyword-no-deprecated/README.md

lib/rules/declaration-property-value-keyword-no-deprecated/__tests__/index.mjs

lib/rules/declaration-property-value-keyword-no-deprecated/index.mjs

lib/rules/declaration-property-value-keyword-no-deprecated/README.md

jeddy3

Thank you for making the changes. The rule is shaping up.

I've made another pass and requested some changes.

lib/rules/declaration-property-value-keyword-no-deprecated/index.mjs

lib/rules/declaration-property-value-keyword-no-deprecated/index.cjs

…perty-value-keyword-no-deprecated`

Co-authored-by: Richard Hallows <[email protected]>

…DME.md

jeddy3

LGTM, thank you.

Let's wait for a second approval before merging.

ybiquitous

Thank you for the pull request. I think there are no more big problems. 👍🏼

I've left some minor refactoring suggestions, so can you please take a look?

lib/rules/declaration-property-value-keyword-no-deprecated/index.mjs

Mouvedia · 2024-12-31T09:30:23Z

lib/rules/declaration-property-value-keyword-no-deprecated/index.mjs

+				let fix;
+				let message;
+				let messageArgs;


note

I wish eslint-config-stylelint would allow

let fix, message, messageArgs;

ybiquitous

Thank you. The code has now become more readable. LGTM 👍🏼

lib/rules/declaration-property-value-keyword-no-deprecated/README.md

Co-authored-by: Richard Hallows <[email protected]>

@romainmenke

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.12.0 | 16.13.0 | ## [v16.13.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16130---2025-01-12) It adds 3 rules to help you write error-free at-rules and 2 rules to warn you about deprecated CSS features. We've turned these rules on in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). It also adds new rule options, a feature to display how long rules take, lax autofix and support for `messageArgs` in more rules. It fixes 7 bugs. Lastly, we've made a deprecation that may affect some plugins. We've updated our docs for [plugin authors](docs/developer-guide/plugins.md#quiet-deprecation-warnings) and [end users](docs/user-guide/options.md#quietdeprecationwarnings) on how to silence deprecation warnings. - Deprecated: ambiguous position arguments passed to `utils.report()` ([#8244](stylelint/stylelint#8244)) ([@romainmenke](https://github.com/romainmenke)). - Added: `lax`/`strict` values to the `fix` Node.js API option and CLI flag ([#8106](stylelint/stylelint#8106)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: support for profiling rule performance via the `TIMING` environment variable ([#8108](stylelint/stylelint#8108)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-descriptor-no-unknown` rule ([#8197](stylelint/stylelint#8197)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-descriptor-value-no-unknown` rule ([#8211](stylelint/stylelint#8211)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-no-deprecated` rule ([#8251](stylelint/stylelint#8251)) ([@jeddy3](https://github.com/jeddy3)). - Added: `at-rule-prelude-no-invalid` rule ([#8268](stylelint/stylelint#8268)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `declaration-property-value-keyword-no-deprecated` rule ([#8223](stylelint/stylelint#8223)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `"ignore": ["at-rule-preludes", "declaration-values"]` to `string-no-newline` ([#8214](stylelint/stylelint#8214)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `messageArgs` to `declaration-property-value-no-unknown`, `font-family-name-quotes`, `font-family-no-duplicate-names`, `function-calc-no-unspaced-operator`, `import-notation`, `media-feature-name-unit-allowed-list`, `selector-attribute-quotes` and `selector-pseudo-element-colon-notation` ([#8285](stylelint/stylelint#8285) & [#8252](stylelint/stylelint#8252)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: deprecation warnings to only display once per (custom) rule ([#8265](stylelint/stylelint#8265)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `*-no-vendor-prefix` message ambiguity ([#8239](stylelint/stylelint#8239)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-(dis)allowed-list`, `at-rule-no-vendor-prefix`, `at-rule-property-required-list` message argument ([#8277](stylelint/stylelint#8277)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message for inclusion of properties and descriptors ([#8207](stylelint/stylelint#8207)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `at-rule-*` false positives and negatives for `@charset` rule ([#8215](stylelint/stylelint#8215)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for descriptors ([#8240](stylelint/stylelint#8240)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `property-(dis)allowed-list` false negatives for custom properties, use `/^--/` to (dis)allow them ([#8209](stylelint/stylelint#8209)) ([@fbasmaison-lucca](https://github.com/fbasmaison-lucca)). - Fixed: `property-no-unknown` false positives for descriptors ([#8203](stylelint/stylelint#8203)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `selector-pseudo-class-no-unknown` false positives for deprecated pseudo-classes ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-case` false positives for `hatchPath` ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-no-unknown` false positives for `shadow`, `hatch` and `hatchpath` ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)).

Manual changes: - removed `indentation` rule (stylelint/stylelint#6504, stylelint/stylelint#6979) - deprecated property `clip` no autofixed (stylelint/stylelint#8699) - removed deprecated `word-break: break-word` (stylelint/stylelint#8223) Automatic changes: - `import-notation` now uses `"url"` (stylelint/stylelint-config-standard#266) - use `inset` instead of `top` `right` `bottom` `left` (stylelint/stylelint#6699) - use `overflow-wrap` instead of `word-wrap` (stylelint/stylelint#8682) - added `media-feature-range-notation` (stylelint/stylelint-config-standard#284) Configuration now in ESM format (https://stylelint.io/migration-guide/to-16).

Mouvedia force-pushed the add-dpvnd branch from b8662c8 to b907c4e Compare December 24, 2024 18:31

Mouvedia commented Dec 24, 2024

View reviewed changes

lib/reference/properties.mjs

],

]);

export const singleValueColorProperties = new Set([

Copy link

Member Author

Mouvedia Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrollbar-color accept 2 colors

Mouvedia force-pushed the add-dpvnd branch from 66160b1 to 1a47662 Compare December 24, 2024 19:44

Mouvedia commented Dec 24, 2024

View reviewed changes

Mouvedia marked this pull request as ready for review December 24, 2024 19:57

Mouvedia requested a review from jeddy3 December 24, 2024 20:05

Mouvedia force-pushed the add-dpvnd branch from 2213e5f to d6f990e Compare December 24, 2024 20:21

Mouvedia commented Dec 24, 2024

View reviewed changes

Mouvedia requested a review from ybiquitous December 25, 2024 05:24

Mouvedia mentioned this pull request Dec 25, 2024

Have declaration-property-value-no-deprecated report "quirky" hex colors #8226

Closed

Mouvedia changed the title ~~Add declaration-property-value-no-deprecated~~ Add declaration-property-value-keyword-no-deprecated Dec 26, 2024

Mouvedia force-pushed the add-dpvnd branch 2 times, most recently from 7701135 to 6efedb0 Compare December 26, 2024 04:57

jeddy3 requested changes Dec 26, 2024

View reviewed changes

jeddy3 reviewed Dec 26, 2024

View reviewed changes

lib/rules/declaration-property-value-keyword-no-deprecated/README.md Show resolved Hide resolved

Mouvedia force-pushed the add-dpvnd branch 2 times, most recently from a043c3b to 08bd6a0 Compare December 26, 2024 12:14

Mouvedia requested a review from jeddy3 December 26, 2024 12:45

jeddy3 requested changes Dec 26, 2024

View reviewed changes

Mouvedia force-pushed the add-dpvnd branch from 57dd7b3 to 36a3b61 Compare December 26, 2024 14:17

Mouvedia requested a review from jeddy3 December 26, 2024 14:29

github-advanced-security bot found potential problems Dec 28, 2024

View reviewed changes

lib/rules/declaration-property-value-keyword-no-deprecated/index.cjs Fixed Show fixed Hide fixed

Mouvedia force-pushed the add-dpvnd branch from 2d69405 to d7d1012 Compare December 28, 2024 22:39

Mouvedia commented Dec 29, 2024

View reviewed changes

lib/rules/declaration-property-value-keyword-no-deprecated/index.cjs Outdated Show resolved Hide resolved

Mouvedia force-pushed the add-dpvnd branch from d7d1012 to ec823a2 Compare December 29, 2024 09:07

Mouvedia added 2 commits December 29, 2024 18:43

WIP

b429c68

remove postcss-value-parser

20cee9a

Mouvedia and others added 11 commits December 29, 2024 18:43

self review 1

88517c7

rename declaration-property-value-no-deprecated to `declaration-pro…

c825778

…perty-value-keyword-no-deprecated`

add ignoreValues secondary option

8e860a3

self review 2

aa51422

code review 1

0e902aa

Co-authored-by: Richard Hallows <[email protected]>

code review 2

7c73fc2

code review 3

b61aab7

Co-authored-by: Richard Hallows <[email protected]>

self review 3

49937e0

Update lib/rules/declaration-property-value-keyword-no-deprecated/REA…

71da988

…DME.md

self review 4

beff66e

self review 5

f0fb495

Mouvedia force-pushed the add-dpvnd branch from 94db521 to f0fb495 Compare December 29, 2024 17:43

jeddy3 approved these changes Dec 29, 2024

View reviewed changes

Mouvedia mentioned this pull request Dec 29, 2024

Add at-rule-no-deprecated #8251

Merged

ybiquitous reviewed Dec 31, 2024

View reviewed changes

Mouvedia force-pushed the add-dpvnd branch from ffe6840 to d401dd6 Compare December 31, 2024 09:18

code review 4

ded139b

Mouvedia force-pushed the add-dpvnd branch from d401dd6 to ded139b Compare December 31, 2024 09:24

Mouvedia commented Dec 31, 2024

View reviewed changes

Mouvedia requested a review from ybiquitous December 31, 2024 09:33

ybiquitous approved these changes Jan 1, 2025

View reviewed changes

jeddy3 reviewed Jan 1, 2025

View reviewed changes

lib/rules/declaration-property-value-keyword-no-deprecated/README.md Show resolved Hide resolved

code review 5

c3a1667

Co-authored-by: Richard Hallows <[email protected]>

Mouvedia force-pushed the add-dpvnd branch from 47553d1 to c3a1667 Compare January 1, 2025 11:21

Mouvedia merged commit 5e79be3 into stylelint:main Jan 1, 2025
17 checks passed

Mouvedia deleted the add-dpvnd branch January 1, 2025 11:31

Mouvedia mentioned this pull request Jan 16, 2025

Fix declaration-property-value-keyword-no-deprecated false positives for border-color #8328

Merged

		### Deprecated

		Disallow deprecated things with these `no-deprecated` rules.

Uh oh!

Add declaration-property-value-keyword-no-deprecated #8223

Add declaration-property-value-keyword-no-deprecated #8223

Uh oh!

Conversation

Mouvedia commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Mouvedia Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

Mouvedia Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

Mouvedia Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mouvedia Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

Mouvedia Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeddy3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

ybiquitous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mouvedia Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

ybiquitous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Add `declaration-property-value-keyword-no-deprecated` #8223

Add `declaration-property-value-keyword-no-deprecated` #8223

Mouvedia commented Dec 24, 2024 •

edited

Loading

changeset-bot bot commented Dec 24, 2024 •

edited

Loading

Mouvedia Dec 24, 2024 •

edited

Loading

Mouvedia Dec 24, 2024 •

edited

Loading

jeddy3 left a comment •

edited

Loading