Expand documentation of declaration-block-no-redundant-longhand-prope… #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties to include discussion of flexbox browser bugs
ntwb
approved these changes
Feb 12, 2018
Arcanemagus
approved these changes
Feb 12, 2018
AlexWayfer
reviewed
Feb 13, 2018
| @@ -60,6 +60,10 @@ This rule complains when the following shorthand properties can be used: | |||
| - `text-emphasis` | |||
| - `mask` | |||
|
|
|||
| **Please note** that properties are considered to be redundant if they may be written shorthand according to the specification, **regardless of the behavior of any individual browser**. For example, due to Internet Explorer's implementation of Flexbox, [it may not be possible to use the shorthand property `flex`](https://github.com/philipwalton/flexbugs#flexbug-8), but the longhand form is still considered a violation. | |||
|
|
|||
| Flexbox-related properties can be ignored using `ignoreShorthands: ["/flex-/"]` (see below). | |||
There was a problem hiding this comment.
It can be just as "flexbox", without Regexp, doesn't it?
There was a problem hiding this comment.
The documentation is a bit confusing as "padding" is given as an example, but the option is ignoreShorthands, and the shorthand properties are flex-basis, flex-grow and flex-shrink. I think I'd have to look at the code to figure out what the actual behaviour is. In any case despite being a regex, this seems more straightforward.
|
There is no information about postcss-flexbugs-fixes 😔 |
|
@AlexWayfer Can you create a pull request to add that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rties to include discussion of flexbox browser bugs
#3144
Documentation change only.