Fix GlobbyOptions TypeScript errors (#8992)

zalishchuk · ybiquitous · web-flow · commit 79cf2cf08223 · 2026-01-28T17:08:34.000Z
Co-authored-by: Masafumi Koba &lt;473530+ybiquitous@users.noreply.github.com&gt;
diff --git a/.changeset/nine-rockets-eat.md b/.changeset/nine-rockets-eat.md
@@ -0,0 +1,5 @@
+---
+"stylelint": patch
+---
+
+Fixed: `GlobbyOptions` TypeScript errors
diff --git a/lib/__tests__/printConfig.test.mjs b/lib/__tests__/printConfig.test.mjs
@@ -72,3 +72,15 @@ it('printConfig with globs should throw', async () => {
 		}),
 	).rejects.toThrow('The --print-config option does not support globs.');
 });
+
+it('printConfig with URL cwd in globbyOptions', async () => {
+	const result = await printConfig({
+		files: ['a/b/foo.css'],
+		globbyOptions: {
+			cwd: new URL('./fixtures/getConfigForFile/', import.meta.url),
+		},
+	});
+
+	expect(result).toHaveProperty('rules');
+	expect(result.rules).toHaveProperty('block-no-empty');
+});
diff --git a/lib/__tests__/standalone-globs.test.mjs b/lib/__tests__/standalone-globs.test.mjs
@@ -184,6 +184,51 @@ describe('standalone globbing', () => {
 			);
 		});
 
+		it('setting "cwd" as URL in globbyOptions', async () => {
+			const cssGlob = `*.+(s|c)ss`;
+
+			const { results } = await standalone({
+				files: cssGlob,
+				config: {
+					rules: {
+						'block-no-empty': true,
+					},
+				},
+				globbyOptions: {
+					cwd: new URL('./fixtures/globs/got[braces] and (spaces)/', import.meta.url),
+				},
+			});
+
+			expect(results).toHaveLength(1);
+			expect(results[0].errored).toBe(true);
+			expect(results[0].warnings[0]).toEqual(
+				expect.objectContaining({
+					rule: 'block-no-empty',
+					severity: 'error',
+				}),
+			);
+		});
+
+		it('setting globbyOptions without cwd falls back to options cwd', async () => {
+			const cssGlob = `*.+(s|c)ss`;
+
+			const { results } = await standalone({
+				files: cssGlob,
+				config: {
+					rules: {
+						'block-no-empty': true,
+					},
+				},
+				cwd: `${fixturesPath}/got[braces] and (spaces)/`,
+				globbyOptions: {
+					dot: false,
+				},
+			});
+
+			expect(results).toHaveLength(1);
+			expect(results[0].errored).toBe(true);
+		});
+
 		it('setting "cwd" in options', async () => {
 			const cssGlob = `*.+(s|c)ss`;
 
diff --git a/lib/printConfig.mjs b/lib/printConfig.mjs
@@ -3,6 +3,7 @@ import process from 'node:process';
 import { isDynamicPattern } from 'globby';
 
 import resolveConfig from './resolveConfig.mjs';
+import toPath from './utils/toPath.mjs';
 
 /** @import {Config as StylelintConfig} from 'stylelint' */
 
@@ -34,7 +35,7 @@ export default async function printConfig({
 
 	return (
 		(await resolveConfig(filePath, {
-			cwd: (globbyOptions && globbyOptions.cwd) || cwd,
+			cwd: toPath(globbyOptions?.cwd) || cwd,
 			config,
 			configBasedir,
 			configFile,
diff --git a/lib/standalone.mjs b/lib/standalone.mjs
@@ -30,6 +30,7 @@ import normalizeFixMode from './utils/normalizeFixMode.mjs';
 import prepareReturnValue from './prepareReturnValue.mjs';
 import resolveFilePath from './utils/resolveFilePath.mjs';
 import resolveOptionValue from './utils/resolveOptionValue.mjs';
+import toPath from './utils/toPath.mjs';
 
 const ALWAYS_IGNORED_GLOBS = ['**/node_modules/**'];
 
@@ -181,7 +182,7 @@ export default async function standalone({
 	}
 
 	let fileList = [files].flat().map((entry) => {
-		const globCWD = (globbyOptions && globbyOptions.cwd) || cwd;
+		const globCWD = toPath(globbyOptions?.cwd) || cwd;
 		const absolutePath = !isAbsolute(entry) ? join(globCWD, entry) : normalize(entry);
 
 		if (existsSync(absolutePath)) {
@@ -208,11 +209,9 @@ export default async function standalone({
 		absolute: true,
 	};
 
-	const globCWD = effectiveGlobbyOptions.cwd;
+	const globCWD = toPath(effectiveGlobbyOptions.cwd);
 
-	let filePaths = (await globby(fileList, effectiveGlobbyOptions)).map((entry) =>
-		typeof entry === 'string' ? entry : entry.path,
-	);
+	let filePaths = await globby(fileList, effectiveGlobbyOptions);
 
 	// Record the length of filePaths before ignore operation
 	// Prevent prompting "No files matching the pattern 'xx' were found." when .stylelintignore ignore all input files
diff --git a/lib/utils/__tests__/toPath.test.mjs b/lib/utils/__tests__/toPath.test.mjs
@@ -0,0 +1,21 @@
+import { fileURLToPath } from 'node:url';
+
+import { describe, expect, test } from '@jest/globals';
+
+import toPath from '../toPath.mjs';
+
+describe('toPath', () => {
+	test('returns string as-is', () => {
+		expect(toPath('/foo/bar')).toBe('/foo/bar');
+	});
+
+	test('converts URL to string path', () => {
+		const url = new URL(import.meta.url);
+
+		expect(toPath(url)).toBe(fileURLToPath(url));
+	});
+
+	test('returns undefined for undefined input', () => {
+		expect(toPath(undefined)).toBeUndefined();
+	});
+});
diff --git a/lib/utils/toPath.mjs b/lib/utils/toPath.mjs
@@ -0,0 +1,23 @@
+import { fileURLToPath } from 'node:url';
+
+/**
+ * Converts a URL to a file path string, or returns the string as-is.
+ *
+ * @overload
+ * @param {string | URL} cwd
+ * @returns {string}
+ *
+ * @overload
+ * @param {undefined} cwd
+ * @returns {undefined}
+ *
+ * @overload
+ * @param {string | URL | undefined} cwd
+ * @returns {string | undefined}
+ *
+ * @param {string | URL | undefined} cwd
+ * @returns {string | undefined}
+ */
+export default function toPath(cwd) {
+	return cwd instanceof URL ? fileURLToPath(cwd) : cwd;
+}
diff --git a/types/stylelint/index.d.ts b/types/stylelint/index.d.ts
@@ -1,5 +1,5 @@
 import type * as PostCSS from 'postcss';
-import type { GlobbyOptions } from 'globby';
+import type { Options as GlobbyOptions } from 'globby';
 import type { cosmiconfig, TransformSync as CosmiconfigTransformSync } from 'cosmiconfig';
 
 type ConfigExtends = string | string[];

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"stylelint": patch
 +---
++
 +Fixed: `GlobbyOptions` TypeScript errors