Conversation
|
Yeah, I'm sort of unsure what to do about some of the miscellaneous properties in the library, there's also Shadows seems sensible though |
|
Looking at https://primer.style/components/docs/system-props – maybe |
|
If you don't think these props should even be included, let me know. I don't think I have used any of the props specifically. If I were to take a stab at putting them somewhere I would say:
But it doesn't feel like a 100% fit. Another random thought: what if we put |
|
Yeah, I think it'd make sense to have a |
| property: 'textShadow', | ||
| scale: 'shadows', | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Thanks for working on this! For the v5 packages, I've been grouping all the utilities into categories so that one import/function will add several style props. E.g. with typography, it adds fontFamily, fontSize, lineHeight, etc. as props. I think this shadow package could follow the same format, where one shadow function adds both boxShadow and textShadow props. To do the same here, it'd mean combining the two system calls into a single one and merging the two configuration options
There was a problem hiding this comment.
Going to merge this as-is and combine these in the v5 branch
2 participants
No description provided.