Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 1
Lines ? 173
Branches ? 0
=======================================
Hits ? 173
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Closed
4 tasks
kof
reviewed
Apr 30, 2019
src/index.js
Outdated
| // loosely based on deepmerge package | ||
| export const merge = (a, b) => { | ||
| const result = {} | ||
| Object.keys(a).forEach(key => { |
There was a problem hiding this comment.
It might be worth doing micro perf optimizations here by using a for loop instead of .keys, .forEach, .reduce, since this is something that will be done a lot.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change undoes the change in v4.0.0 where the returned value is an array of styles, favoring a merged object instead. The merge implementation is loosely based on the
deepmergepackage, but only handles objects and does not check for null, falsy or array values. This shouldn't entail a breaking change for most users, but does change the returned valuesPartially fixes #471