Repository navigation
fix: exclude ignored notation from chord diagrams - #77
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70.
Summary
N.C.from the chord names usedto render diagrams.
D/F#, and theexisting annotation filtering.
when chord lines are parsed.
Why
ChordSheet#unique_chordsfeeds both the guitar and ukulele diagram renderers.It removed bracketed annotations, but it still returned other permitted
chord-sheet notation as chord names. A bar line such as
|therefore reachedthe renderer and produced a missing-chord placeholder.
The updated sanitization mirrors the ignored notation used when classifying
chord lines, so
D |: D/F# :| G* N.C.now yields onlyD,D/F#, andG.Testing
The default Rake pipeline reached Cypress after all preceding checks passed.
The full Cypress run completed 48 of 51 cases; its three failures were unrelated
textarea/sorting timing cases. Focused reruns changed the failure set, and the
exact pre-change base also reproduced existing sorting and version-history
timing failures.