Skip to content

provide new option gitr.echo_cmd defaulting to FALSE #14

Closed

Description

@malcook

The git function defaults its echo_cmd argument to FALSE:

gitr/R/git.R

Line 35 in c5aebda

git <- function(..., echo_cmd = TRUE) {

Some gitr functions pass in FALSE for this, but most do not pass anything, e.g.

git_recent_tag

It would be useful to be able to suppress all echoing of git commands through the use of an option, e.g.

options(gitr.echo_cmd=FALSE)

Activity

  1. stufield commented on Jul 8, 2024

    @stufield
    Owner

    Hey, thanks for the issue!

    I'll see what I can do ... generally I avoid forcing users to set global options (mostly because I hate having to do this myself as a user), but your issue highlights the need for some coding consistency.

    I'll take a closer look and see how I can make things a bit smoother.

  2. stufield commented on Jul 8, 2024

    @stufield
    Owner

    I assume in your post you meant:

    "The git function defaults its echo_cmd argument to TRUE:"
    

    in the OP?

  3. self-assigned this
    on Jul 8, 2024
  4. added 3 commits that reference this issue on Jul 8, 2024
    26bd58f
    ee3a1ee
    1988b9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions