Get out of dependency 'heck' #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kienstra
commented
Jul 25, 2023
| "plugin:import/recommended", | ||
| "plugin:eslint-comments/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| "plugin:jest-dom/recommended", |
Contributor
Author
There was a problem hiding this comment.
This was for Jest unit tests of React components, which I deleted
kienstra
commented
Jul 25, 2023
| "license": "GPL-2.0", | ||
| "require": { | ||
| "php": "^5.6 || ^7 || ^8" | ||
| "php": "^7 || ^8" |
Contributor
Author
There was a problem hiding this comment.
Core 6.3 doesn't support PHP 5.6 anymore.
That's a good excuse to remove our support, as it's really hard to make composer install work for PHP 5.6-8.2.
kienstra
commented
Jul 25, 2023
|
|
||
| const testImagePath = path.join( __dirname, '..', 'assets', fileName ); | ||
| const newFileName = uuid(); | ||
| const newFileName = Math.floor( Math.random( 100000 ) * 100000 ); |
Contributor
Author
There was a problem hiding this comment.
No need to import uuid, we can do this in 1 line of JS.
dreamwhisper
approved these changes
Jul 27, 2023
Contributor
Author
|
Hi @dreamwhisper, |
Ease of release: Replace `gulp` with `wp-svn` orb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Every time I updated npm packages, that caused errors with Jest unit tests or
npm run build.And
composer installfailed on PHP8.2, as the packages weren't compatible with8.2.After
The npm package versions don't matter much anymore.
And it'll be easier to update package versions, without a Jest or PHPUnit error.
Changes
Reactversions being out of sync.--webpack-no-externals. This should make npm package updates less necessary. The block editor will alias them to whatever packages it's using.Testing instructions
Not needed