Skip to content

Bump 'Tested up to' to 6.2 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kienstra merged 2 commits into from
Mar 30, 2023
Merged

Bump 'Tested up to' to 6.2 #141

kienstra merged 2 commits into from
Mar 30, 2023

Conversation

@kienstra
Copy link
Contributor

@kienstra kienstra commented Mar 29, 2023 •
edited
Loading

Changes

  • Bump 'Tested up to' to 6.2
  • Change PHP requirement from 5.6 to 7.0
  • This is lazy on my part. PHPUnit tests failed on PHP 5.6, and I don't know how to fix them.
  • PHP 5.6 has been EOL for 4 years.

Testing instructions

Not needed, already tested in #140

@kienstra
Copy link
Contributor Author

kienstra commented Mar 29, 2023

The 'Tested up to' deployment worked.

@kienstra kienstra marked this pull request as ready for review March 29, 2023 21:50
dreamwhisper
dreamwhisper approved these changes Mar 30, 2023
View reviewed changes
.circleci/config.yml
only: /.*/
matrix:
parameters:
php-version: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1' ]
Copy link
Contributor

@dreamwhisper dreamwhisper Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

Copy link
Contributor Author

@kienstra kienstra Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, yeah!

@kienstra
Copy link
Contributor Author

kienstra commented Mar 30, 2023

Thanks a lot, @dreamwhisper!

@kienstra kienstra merged commit ab13add into develop Mar 30, 2023
@kienstra kienstra deleted the bump-tested-up-to-6.2 branch March 30, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnstonphilip johnstonphilip Awaiting requested review from johnstonphilip

@mike-day mike-day Awaiting requested review from mike-day

@mikemcalister mikemcalister Awaiting requested review from mikemcalister

1 more reviewer

@dreamwhisper dreamwhisper dreamwhisper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kienstra @dreamwhisper