feat(profiles): add configuration profiles infrastructure by polaz · Pull Request #60 · structured-world/gitlab-mcp

polaz · 2026-01-20T08:47:29Z

Summary

Closes #54

Add support for named configuration profiles and presets that enable multi-GitLab workflows and role-based access patterns.

Key Changes

Profile/Preset separation for security:
- Profile = full config with host/auth (user-defined only)
- Preset = settings only, NO host/auth (built-in, safe for testing)
ProfileLoader class with caching and validation
applyProfile() function to map settings to environment variables
CLI integration: --profile <name> argument and GITLAB_PROFILE env var
Built-in presets: readonly, developer, admin
67 unit tests covering all components

Security

Built-in presets NEVER contain host or auth to prevent accidental requests to wrong GitLab instances during testing.

Files

File	Purpose
`src/profiles/types.ts`	Zod schemas for Profile/Preset
`src/profiles/loader.ts`	ProfileLoader class
`src/profiles/applicator.ts`	Apply profile to env vars
`src/profiles/index.ts`	Module exports
`src/profiles/builtin/*.yaml`	Built-in presets
`src/main.ts`	CLI --profile support

Test plan

Unit tests pass (67 new tests)
Full test suite passes (1900 tests)
Lint passes
Build passes

Add support for named configuration profiles and presets: - Profile: full config with host/auth (user-defined in ~/.config/gitlab-mcp/profiles.yaml) - Preset: settings only, NO host/auth (built-in safe for testing) Features: - ProfileLoader class with caching and validation - applyProfile() to map profile settings to env vars - --profile CLI argument and GITLAB_PROFILE env var support - Built-in presets: readonly, developer, admin - Zod schemas for type-safe validation - 67 unit tests covering loader, applicator, types Security: Built-in presets NEVER contain host/auth to prevent accidental requests to wrong GitLab instances during testing.

github-actions · 2026-01-20T08:48:35Z

📊 Test Coverage Report

Overall Coverage: 87.67%

Coverage Details

Metric	Percentage
Statements	87.67%
Branches	80.55%
Functions	73.2%
Lines	88.18%

Coverage Report: View detailed coverage report

This report was generated automatically from your PR changes.

codecov · 2026-01-20T08:49:21Z

Codecov Report

❌ Patch coverage is 86.93182% with 46 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/main.ts	43.33%	15 Missing and 2 partials ⚠️
src/profiles/index.ts	0.00%	11 Missing ⚠️
src/profiles/applicator.ts	93.15%	1 Missing and 9 partials ⚠️
src/profiles/loader.ts	94.87%	4 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR introduces configuration profiles infrastructure to enable multi-GitLab workflows and role-based access patterns. The implementation separates full profiles (with host/auth) from presets (settings only) for security purposes.

Changes:

Added Profile/Preset type system with Zod schemas for validation
Implemented ProfileLoader class for loading and caching profiles from YAML files
Created profile applicator to map settings to environment variables
Integrated CLI support with --profile argument and GITLAB_PROFILE env var
Added three built-in presets: readonly, developer, and admin
Included 67 comprehensive unit tests

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/profiles/types.ts	Zod schemas and TypeScript types for Profile and Preset configurations
src/profiles/loader.ts	ProfileLoader class with caching, validation, and YAML parsing
src/profiles/applicator.ts	Functions to apply profile settings to environment variables
src/profiles/index.ts	Module exports for the profiles subsystem
src/profiles/builtin/*.yaml	Three built-in preset configurations (readonly, developer, admin)
src/main.ts	CLI integration for --profile argument and profile loading
tests/unit/profiles/*.test.ts	Comprehensive unit tests (67 tests total)
tests/unit/main.test.ts	Updated tests to reflect new main() function structure
tests/unit/main.entry.test.ts	Updated entry point tests with profile mocking
package.json	Added yaml dependency
yarn.lock	Lockfile update for yaml package

src/profiles/types.ts

src/main.ts

src/profiles/applicator.ts

src/profiles/loader.ts

- Add applyPreset() function for runtime built-in preset application - Add .strict() to PresetSchema to reject unknown fields (security) - Validate --profile CLI argument is not another flag - Validate OAuth client_secret_env environment variable - Validate cookie auth file path exists

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

src/profiles/loader.ts

- Add build:copy-assets script to copy YAML presets to dist - Update getBuiltinDir() to use __dirname for npm package compatibility - Add Node.js CommonJS globals to ESLint config - Add 45+ tests for applyPreset, loadAndApplyProfile, loadAndApplyPreset - Add validation tests for OAuth, cookie auth, and TLS paths - Add profile handling tests for main.ts CLI integration Closes #54

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

package.json

src/main.ts

…rning - Replace Unix shell commands with Node.js one-liner for cross-platform compatibility - Add warning when multiple --profile flags are provided

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.

src/profiles/applicator.ts

src/profiles/loader.ts

…orkflow)

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

.github/workflows/pr-check.yml

src/profiles/applicator.ts

src/profiles/types.ts

Add environment variable mappings for: - allowed_groups -> GITLAB_ALLOWED_GROUP_IDS - allowed_tools -> GITLAB_ALLOWED_TOOLS (in applyProfile) - default_namespace -> GITLAB_DEFAULT_NAMESPACE These fields were defined in the Profile type but not applied to environment variables when the profile was loaded.

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

src/profiles/loader.ts

package.json

src/main.ts

- Improve denied_actions validation to check both tool and action parts are non-empty (fixes ':action', 'tool:', ':' edge cases) - Fix getProfileNameFromEnv JSDoc comment accuracy - Move multiple --profile warning outside loop with count - Add tests for denied_actions edge cases

polaz · 2026-01-20T13:12:13Z

Fixed in cf7fa57:

JSDoc comment updated to accurately describe the function
denied_actions validation now checks both tool and action parts are non-empty
Multiple --profile warning moved outside loop with count

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

src/profiles/loader.ts

src/profiles/applicator.ts

Add tests for: - allowed_groups, allowed_tools, default_namespace env var mapping - validation warnings logging path - getProfileNameFromEnv standalone function Coverage improved: - applicator.ts: 94.44% -> 99.3% - loader.ts: 95.56% -> 96.2% - Overall profiles: 91.07% -> 93.53%

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

.github/workflows/pr-check.yml

Add tests for: - Alphabetical sorting within same profile category - Config cache hit when loading multiple profiles Coverage improved: - loader.ts: 96.2% -> 97.46% - Overall profiles: 93.53% -> 94.15%

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

.github/workflows/pr-check.yml

src/profiles/loader.ts

Warn users when denied_actions entries contain extra whitespace around the colon (e.g., "tool : action"). The validation still passes but logs a warning indicating the normalized form.

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

src/profiles/loader.ts

Reduces code duplication between validateProfile and validatePreset by extracting shared denied_actions validation logic into a private helper method.

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated no new comments.

## [6.13.0](v6.12.0...v6.13.0) (2026-01-20) ### Features * **profiles:** add configuration profiles infrastructure ([#60](#60)) ([171b625](171b625)), closes [#54](#54) [#54](#54)

Copilot AI review requested due to automatic review settings January 20, 2026 08:47

Copilot started reviewing on behalf of polaz January 20, 2026 08:48 View session

chore: update Yarn to 4.12.0

168bec5

polaz added 2 commits January 20, 2026 10:51

ci: update Yarn to 4.12.0 in workflows

8156f35

fix(ci): remove yarnPath from .yarnrc.yml (corepack handles it)

b0118c5

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/types.ts Outdated Show resolved Hide resolved

src/main.ts Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/loader.ts Show resolved Hide resolved

src/profiles/loader.ts Show resolved Hide resolved

polaz added 2 commits January 20, 2026 10:54

Merge branch 'main' into feat/54-profiles-infrastructure

6f897e0

polaz requested a review from Copilot January 20, 2026 09:02

Copilot started reviewing on behalf of polaz January 20, 2026 09:02 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/loader.ts Outdated Show resolved Hide resolved

polaz requested a review from Copilot January 20, 2026 09:23

Copilot started reviewing on behalf of polaz January 20, 2026 09:23 View session

fix(docker): update yarn version to 4.12.0 in Dockerfile

1a28e08

Copilot AI reviewed Jan 20, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/main.ts Show resolved Hide resolved

fix(profiles): cross-platform build script and duplicate --profile wa…

f14cff5

…rning - Replace Unix shell commands with Node.js one-liner for cross-platform compatibility - Add warning when multiple --profile flags are provided

polaz requested a review from Copilot January 20, 2026 09:31

Copilot started reviewing on behalf of polaz January 20, 2026 09:32 View session

fix(ci): add explicit yarn 4.12.0 install to pr-check workflow

402529c

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/loader.ts Show resolved Hide resolved

fix(ci): remove pull_request_target from pr-check (uses base branch w…

ebb263a

…orkflow)

polaz requested a review from Copilot January 20, 2026 09:44

Copilot started reviewing on behalf of polaz January 20, 2026 09:44 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

.github/workflows/pr-check.yml Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/types.ts Show resolved Hide resolved

polaz requested a review from Copilot January 20, 2026 10:44

Copilot started reviewing on behalf of polaz January 20, 2026 10:45 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/loader.ts Show resolved Hide resolved

src/profiles/loader.ts Outdated Show resolved Hide resolved

src/profiles/loader.ts Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

src/main.ts Outdated Show resolved Hide resolved

polaz requested a review from Copilot January 20, 2026 13:15

Copilot started reviewing on behalf of polaz January 20, 2026 13:16 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/loader.ts Outdated Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

src/profiles/applicator.ts Show resolved Hide resolved

polaz requested a review from Copilot January 20, 2026 13:41

Copilot started reviewing on behalf of polaz January 20, 2026 13:42 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

.github/workflows/pr-check.yml Show resolved Hide resolved

polaz added 2 commits January 20, 2026 16:18

docs(ci): add comment explaining pull_request trigger choice

19142e8

test(profiles): improve coverage for loader

13bae8f

Add tests for: - Alphabetical sorting within same profile category - Config cache hit when loading multiple profiles Coverage improved: - loader.ts: 96.2% -> 97.46% - Overall profiles: 93.53% -> 94.15%

polaz requested a review from Copilot January 20, 2026 14:43

Copilot started reviewing on behalf of polaz January 20, 2026 14:44 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

.github/workflows/pr-check.yml Show resolved Hide resolved

src/profiles/loader.ts Outdated Show resolved Hide resolved

fix(profiles): add warning for denied_actions with extra whitespace

2243a39

Warn users when denied_actions entries contain extra whitespace around the colon (e.g., "tool : action"). The validation still passes but logs a warning indicating the normalized form.

polaz requested a review from Copilot January 20, 2026 15:30

Copilot started reviewing on behalf of polaz January 20, 2026 15:30 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

src/profiles/loader.ts Show resolved Hide resolved

refactor(profiles): extract validateDeniedActions helper method

ae730f5

Reduces code duplication between validateProfile and validatePreset by extracting shared denied_actions validation logic into a private helper method.

polaz requested a review from Copilot January 20, 2026 15:38

Copilot started reviewing on behalf of polaz January 20, 2026 15:38 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

polaz merged commit 171b625 into main Jan 20, 2026
23 checks passed

polaz deleted the feat/54-profiles-infrastructure branch January 20, 2026 15:41

sw-release-bot bot mentioned this pull request Mar 29, 2026

chore(main): release gitlab-mcp 7.0.0 #368

Open

Conversation

polaz commented Jan 20, 2026

Summary

Key Changes

Security

Files

Test plan

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Test Coverage Report

Coverage Details

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

polaz commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited

Loading