feat(docs): consent banner + vue-privacy 1.2.2 with gtag fix#255
Merged
Conversation
- Add ConsentBanner to layout-bottom slot (fixes banner not showing) - Update @structured-world/vue-privacy ^1.1.0 → ^1.2.2 - Fixes gtag dataLayer.push using Array instead of Arguments - Fixes consent banner race condition (bannerPending)
Test Coverage ReportOverall Coverage: 95.56%
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This pull request adds GDPR-compliant cookie consent functionality to the VitePress documentation site by integrating the @structured-world/vue-privacy package (v1.2.2). The update includes critical bug fixes for Google Analytics tracking and resolves a banner rendering issue by adding the ConsentBanner component to the layout.
Changes:
- Update
@structured-world/vue-privacyfrom 1.1.0 to 1.2.2 with bug fixes for GA4 gtag and banner race conditions - Replace manual Google Analytics implementation with
enhanceWithConsentwrapper - Add
ConsentBannercomponent to the layout-bottom slot alongside the existingBugReportWidget
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Add @structured-world/vue-privacy v1.2.2 to devDependencies |
| yarn.lock | Update lockfile with new package version and peer dependency metadata |
| docs/.vitepress/theme/index.ts | Replace manual GA implementation with vue-privacy integration and add ConsentBanner to layout |
- Add comment that /api/consent is served by Cloudflare Worker
consentTheme may provide its own Layout — using DefaultTheme.Layout directly bypasses consent-aware layout enhancements.
sw-release-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
## [6.51.0](v6.50.0...v6.51.0) (2026-02-02) ### Features * **docs:** consent banner + vue-privacy 1.2.2 with gtag fix ([#255](#255)) ([75eb54b](75eb54b)) ### Bug Fixes * **ci:** prevent transitive skip propagation in release pipeline ([#266](#266)) ([f809a7a](f809a7a)), closes [#264](#264) [#265](#265) [#265](#265) * **ci:** replace heredoc with quoted strings in thread-gate job ([#246](#246)) ([9470b50](9470b50)), closes [#243](#243) [#245](#245) * **ci:** unblock release pipeline on push to main ([#264](#264)) ([59b8cbe](59b8cbe)), closes [#263](#263) * **deps:** update hono from 4.11.5 to 4.11.7 ([#248](#248)) ([71cc831](71cc831)), closes [#247](#247) * **docs:** resolve SEO issues in VitePress documentation ([#249](#249)) ([#250](#250)) ([3e05717](3e05717)) * **docs:** use canonical URL for TOOLS reference in README ([#252](#252)) ([5ac56cc](5ac56cc)), closes [#251](#251) * **pipelines:** serialize array query params as key[] for GitLab Rails API ([#262](#262)) ([955a3c1](955a3c1)), closes [#261](#261)
|
🎉 This PR is included in version 6.51.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsentBannercomponent to layout-bottom slot (fixes banner not rendering)@structured-world/vue-privacyfrom 1.1.0 → 1.2.2:argumentsinstead of Array indataLayer.push— GA4 collect requests were never sentbannerPendingdeferred show)Related to #219