Skip to content

fix(ci): replace heredoc with quoted strings in thread-gate job#246

Merged
polaz merged 1 commit intomainfrom
fix/#245-ci-yaml-heredoc
Jan 31, 2026
Merged

fix(ci): replace heredoc with quoted strings in thread-gate job#246
polaz merged 1 commit intomainfrom
fix/#245-ci-yaml-heredoc

Conversation

@polaz
Copy link
Copy Markdown
Member

@polaz polaz commented Jan 30, 2026

Summary

  • Replace bash heredoc (<<'EOF') with single-quoted strings for GraphQL queries in the review-thread-gate CI job
  • Heredoc content starting at column 0 broke YAML literal block scalar parsing, causing all push events on ci-cd.yml to fail with "workflow file issue" since Gate heavy CI jobs on unresolved review threads #243
  • All pull_request events were unaffected (different GitHub Actions validation path)

Root Cause

In YAML run: | blocks, all content lines must maintain indentation >= the first content line. The heredoc body (query($owner:String!...)) started at column 0, terminating the YAML block prematurely.

Test plan

  • Verify this PR's CI passes (ci-cd.yml triggers on pull_request)
  • After merge, verify push-triggered ci-cd.yml run succeeds on main

Fixes #245

- Heredoc content at column 0 broke YAML literal block scalar parsing
- All push events on ci-cd.yml failed since #243
- GraphQL queries now use single-quoted bash strings with proper indentation

Fixes #245
Copilot AI review requested due to automatic review settings January 30, 2026 20:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes GitHub Actions YAML parsing failures on push events by removing a bash heredoc that broke the run: | block indentation rules in the review-thread-gate job.

Changes:

  • Replace heredoc-based GraphQL query construction with single-quoted, multi-line bash strings in review-thread-gate.
  • Preserve GraphQL query behavior while ensuring YAML block scalar indentation remains valid.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@polaz polaz merged commit 9470b50 into main Jan 31, 2026
28 checks passed
@polaz polaz deleted the fix/#245-ci-yaml-heredoc branch January 31, 2026 01:27
sw-release-bot bot pushed a commit that referenced this pull request Feb 2, 2026
## [6.51.0](v6.50.0...v6.51.0) (2026-02-02)

### Features

* **docs:** consent banner + vue-privacy 1.2.2 with gtag fix ([#255](#255)) ([75eb54b](75eb54b))

### Bug Fixes

* **ci:** prevent transitive skip propagation in release pipeline ([#266](#266)) ([f809a7a](f809a7a)), closes [#264](#264) [#265](#265) [#265](#265)
* **ci:** replace heredoc with quoted strings in thread-gate job ([#246](#246)) ([9470b50](9470b50)), closes [#243](#243) [#245](#245)
* **ci:** unblock release pipeline on push to main ([#264](#264)) ([59b8cbe](59b8cbe)), closes [#263](#263)
* **deps:** update hono from 4.11.5 to 4.11.7 ([#248](#248)) ([71cc831](71cc831)), closes [#247](#247)
* **docs:** resolve SEO issues in VitePress documentation ([#249](#249)) ([#250](#250)) ([3e05717](3e05717))
* **docs:** use canonical URL for TOOLS reference in README ([#252](#252)) ([5ac56cc](5ac56cc)), closes [#251](#251)
* **pipelines:** serialize array query params as key[] for GitLab Rails API ([#262](#262)) ([955a3c1](955a3c1)), closes [#261](#261)
@sw-release-bot
Copy link
Copy Markdown

sw-release-bot bot commented Feb 2, 2026

🎉 This PR is included in version 6.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): YAML heredoc syntax breaks ci-cd.yml on push events

2 participants