Skip to content

Gate heavy CI jobs on unresolved review threads#243

Merged
polaz merged 18 commits intomainfrom
chore/pr-thread-gate
Jan 29, 2026
Merged

Gate heavy CI jobs on unresolved review threads#243
polaz merged 18 commits intomainfrom
chore/pr-thread-gate

Conversation

@polaz
Copy link
Copy Markdown
Member

@polaz polaz commented Jan 28, 2026 •
edited
Loading

Adds a review-thread gate to skip heavy jobs on PRs when review threads are unresolved.

  • New review-thread-gate job checks unresolved threads via GraphQL.
  • docker-build runs only if gate allows (PRs with unresolved threads skip heavy jobs).
  • Non-PR events bypass gate and proceed normally.
  • Added expected-status job as legacy required status check (migrates from old ruleset requirement).

Copilot AI review requested due to automatic review settings January 28, 2026 11:06
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a review thread gate mechanism to skip expensive Docker builds when pull requests have unresolved review threads, optimizing CI resource usage.

Changes:

  • Adds a new review-thread-gate job that queries GitHub's GraphQL API to check for unresolved, non-outdated review threads
  • Modifies docker-build job to depend on the gate and conditionally skip when review threads are unresolved
  • Includes a minor whitespace cleanup (removing trailing space from line 456)

@polaz polaz requested a review from Copilot January 28, 2026 11:38
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

@polaz polaz requested a review from Copilot January 28, 2026 13:03
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

@polaz polaz requested a review from Copilot January 28, 2026 13:20
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

@polaz polaz requested a review from Copilot January 28, 2026 20:37
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@polaz polaz requested a review from Copilot January 28, 2026 21:07
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@polaz polaz requested a review from Copilot January 28, 2026 21:19
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

@polaz polaz requested a review from Copilot January 28, 2026 21:32
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@polaz polaz requested a review from Copilot January 28, 2026 21:45
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

@polaz polaz requested a review from Copilot January 28, 2026 22:10
polaz added 13 commits January 30, 2026 00:24
@polaz
ci(workflows): tighten review gate parsing
a7d41f0 
- quote output paths and harden jq defaults
@polaz
ci(workflows): clarify docker gate
d91b736 
- document non-pr behavior for heavy jobs
@polaz
ci(workflows): respect default branch
a01233c 
- allow docker build on default branch pushes

- clarify skip reason for non-default branches
@polaz
ci(workflows): guard missing gh cli
c91903f 
- fail-open when gh is unavailable in review gate
@polaz
ci(workflows): allow push builds
959de5c 
- run docker build on all push events

- simplify skip reporting
@polaz
ci(workflows): skip gate on non-pr
b2cd6a3 
- only run review gate on pull_request

- clarify summary when gate is skipped
@polaz
ci(workflows): gate only on prs
b3d3bfb 
- allow non-pr events to run docker build

- add pagination empty-page guard
@polaz
ci(summary): remove unreachable review gate status
7aa23ac 
- drop summary branch that can never occur with current gate
@polaz
ci(gate): harden review gate pagination
cff6ede 
- add timeout and readable graphql queries

- validate page counts and simplify docker gate
@polaz
ci(gate): fail closed on pagination cap
3d0d9b3 
- block heavy jobs when review scan is incomplete

- tighten docker-build gate and summary cases
@polaz
ci(summary): clarify docker skip reasons
989cba1 
- drop redundant event check in gate

- distinguish skipped vs failed gate in summary
@polaz
ci(gate): document pagination behavior
17658e0 
- explain fail-open vs fail-closed decisions

- clarify thread filtering and cursor handling
@polaz
ci(checks): report expected status
ed5138e 
Add expected-status job so required check is reported
@polaz polaz force-pushed the chore/pr-thread-gate branch from ac3bde6 to ed5138e Compare January 29, 2026 22:25
@polaz polaz requested a review from Copilot January 29, 2026 22:26
Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@polaz
fix(ci): correct job name typo and document expected-status
f9f4d7a 
- Fix typo: 'BuildExpected' -> 'Build' (proper spacing)
- Add comment explaining expected-status job purpose
- This job provides legacy status check for branch protection
@polaz polaz requested a review from Copilot January 29, 2026 22:35
Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@polaz polaz merged commit 54c6358 into main Jan 29, 2026
19 checks passed
@polaz polaz deleted the chore/pr-thread-gate branch January 29, 2026 22:48
@polaz polaz mentioned this pull request Jan 30, 2026
Closed
polaz added a commit that referenced this pull request Jan 30, 2026
@polaz
fix(ci): replace heredoc with quoted strings in thread-gate job
8ab5b68 
- Heredoc content at column 0 broke YAML literal block scalar parsing
- All push events on ci-cd.yml failed since #243
- GraphQL queries now use single-quoted bash strings with proper indentation

Fixes #245
@polaz polaz mentioned this pull request Jan 30, 2026
Merged
2 tasks
polaz added a commit that referenced this pull request Jan 31, 2026
@polaz
fix(ci): replace heredoc with quoted strings in thread-gate job (#246)
9470b50 
- Heredoc content at column 0 broke YAML literal block scalar parsing
- All push events on ci-cd.yml failed since #243
- GraphQL queries now use single-quoted bash strings with proper indentation

Fixes #245
sw-release-bot bot pushed a commit that referenced this pull request Feb 2, 2026
@semantic-release-bot
chore(release): 6.51.0 [skip ci]
a4e4b32 
## [6.51.0](v6.50.0...v6.51.0) (2026-02-02)

### Features

* **docs:** consent banner + vue-privacy 1.2.2 with gtag fix ([#255](#255)) ([75eb54b](75eb54b))

### Bug Fixes

* **ci:** prevent transitive skip propagation in release pipeline ([#266](#266)) ([f809a7a](f809a7a)), closes [#264](#264) [#265](#265) [#265](#265)
* **ci:** replace heredoc with quoted strings in thread-gate job ([#246](#246)) ([9470b50](9470b50)), closes [#243](#243) [#245](#245)
* **ci:** unblock release pipeline on push to main ([#264](#264)) ([59b8cbe](59b8cbe)), closes [#263](#263)
* **deps:** update hono from 4.11.5 to 4.11.7 ([#248](#248)) ([71cc831](71cc831)), closes [#247](#247)
* **docs:** resolve SEO issues in VitePress documentation ([#249](#249)) ([#250](#250)) ([3e05717](3e05717))
* **docs:** use canonical URL for TOOLS reference in README ([#252](#252)) ([5ac56cc](5ac56cc)), closes [#251](#251)
* **pipelines:** serialize array query params as key[] for GitLab Rails API ([#262](#262)) ([955a3c1](955a3c1)), closes [#261](#261)
@sw-release-bot
Copy link
Copy Markdown

sw-release-bot bot commented Feb 2, 2026

🎉 This PR is included in version 6.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polaz