fix(logging): Apply LOG_JSON pattern to all logger calls by polaz · Pull Request #211 · structured-world/gitlab-mcp

polaz · 2026-01-25T13:39:25Z

Summary

Create helper functions (logInfo, logWarn, logError, logDebug) in logger.ts
Convert all logger calls from logger.level({data}, "message") to logLevel("message", {data}) format
Update all test mocks to include helper functions and match new argument order

Changes

74 files modified (42 source files, 32 test files)
1267 insertions, 1220 deletions

Test plan

All 4116 tests pass
Lint passes with 0 errors
Build succeeds

Closes #209

- Create helper functions (logInfo, logWarn, logError, logDebug) in logger.ts - Convert all logger calls from logger.level({data}, "message") to logLevel("message", {data}) format - Update test mocks to include helper functions and match new argument order - Fix 74 files across src/ and tests/ to use consistent logging pattern Closes #209

github-actions · 2026-01-25T13:40:37Z

Test Coverage Report

Overall Coverage: 94.44%

Metric	Percentage
Statements	93.89%
Branches	85.51%
Functions	84.55%
Lines	94.44%

View detailed coverage report

codecov · 2026-01-25T13:41:43Z

Codecov Report

❌ Patch coverage is 81.14035% with 86 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/server.ts	66.03%	18 Missing ⚠️
src/oauth/session-store.ts	51.72%	14 Missing ⚠️
src/services/ConnectionManager.ts	53.84%	8 Missing and 4 partials ⚠️
src/oauth/storage/postgresql.ts	12.50%	7 Missing ⚠️
src/handlers.ts	57.14%	6 Missing ⚠️
src/services/GitLabVersionDetector.ts	44.44%	2 Missing and 3 partials ⚠️
src/logger.ts	87.50%	0 Missing and 4 partials ⚠️
src/entities/context/whoami.ts	75.00%	0 Missing and 2 partials ⚠️
src/oauth/storage/factory.ts	50.00%	2 Missing ⚠️
src/oauth/storage/file.ts	87.50%	2 Missing ⚠️
... and 12 more

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR fixes multiline logging output by implementing helper functions that handle both JSON and plain text logging modes consistently across the codebase.

Changes:

Created four helper functions (logInfo, logWarn, logError, logDebug) in src/logger.ts that automatically format logs based on LOG_JSON environment variable
Converted 144 logger calls from logger.level({data}, "message") to logLevel("message", {data}) format across 42 source files
Updated test mocks in 32 test files to include the new helper functions and match the new argument order
Removed obsolete prettyPrint option from file storage configuration

Reviewed changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/logger.ts	Added four helper functions (logInfo, logWarn, logError, logDebug) with formatDataPairs utility
src/main.ts	Updated all logger calls to use new helpers with correct argument order
src/server.ts	Converted 30+ logger calls to new helper pattern
src/session-manager.ts	Updated session lifecycle logging to use helpers
src/services/ConnectionManager.ts	Converted connection and schema introspection logging
src/services/TokenScopeDetector.ts	Updated token scope detection and logging
src/services/SchemaIntrospector.ts	Converted GraphQL schema introspection logging
src/services/ToolAvailability.ts	Updated tool availability logging
src/services/WidgetAvailability.ts	Converted widget validation logging
src/services/GitLabVersionDetector.ts	Updated version detection logging
src/utils/fetch.ts	Converted all fetch-related logging (requests, retries, errors)
src/utils/schema-utils.ts	Updated schema mode detection and filtering logging
src/registry-manager.ts	Converted registry filtering and tool override logging
src/profiles/*.ts	Updated all profile/preset loading and application logging (4 files)
src/oauth/*/.ts	Converted OAuth flow, session, and storage logging (10 files)
src/middleware/*.ts	Updated middleware logging for auth and rate limiting (2 files)
src/entities/*/.ts	Converted entity-specific logging (3 files)
src/discovery/*.ts	Updated auto-discovery logging (3 files)
src/cli-utils.ts	Converted CLI argument parsing logging
src/handlers.ts	Updated MCP request handler logging
src/graphql/DynamicWorkItemsQuery.ts	Converted query building logging
src/logging/request-tracker.ts	Updated request tracking debug logging
src/logging/connection-tracker.ts	Converted to use logInfo and logDebug helpers
src/oauth/storage/types.ts	Removed prettyPrint option from StorageConfig
tests/unit/*/.test.ts	Updated 20 test files to mock helper functions
tests/integration/*/.test.ts	Updated integration test mocks (1 file)

src/logger.ts

- Add tests for logInfo, logWarn, logError, logDebug functions - Test JSON mode and plain mode output formats - Test nested objects and various data types handling Related to #209

- Add special case for Error objects to preserve stack/message - Handle null and undefined values explicitly - Add tests for Error and undefined handling Related to #209

Copilot

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated no new comments.

…arning - Add test for 429 response when IP rate limit exceeded - Add test for debug log when approaching 80% threshold - Use unique IPs per test to ensure per-IP isolation Related to #209

- Add test for error when called before initialization - Add test for early return when already introspected Related to #209

Copilot

Pull request overview

Copilot reviewed 76 out of 76 changed files in this pull request and generated no new comments.

- Add test verifying separate rate limits tracked per IP address - Add test for 429 response when IP rate limit exceeded - Add test for debug log when approaching 80% threshold

…pping - Add Authorization Code Flow tests (store, get, delete, count) - Add MCP session mapping tests (associate, get by MCP session, remove) - Add tests for getBackendType, getStats, clear, stopCleanupInterval - Add tests for getSessionCount, getDeviceFlowCount, getAuthCodeCount - Add updateSession edge case tests (non-existent, refresh token update)

- Add tests for registerHandler (public/confidential clients, validation) - Add tests for getRegisteredClient and isValidRedirectUri - Add test for error handling in registration

Copilot

Pull request overview

Copilot reviewed 78 out of 78 changed files in this pull request and generated no new comments.

## [6.46.1](v6.46.0...v6.46.1) (2026-01-25) ### Bug Fixes * **logging:** Apply LOG_JSON pattern to all logger calls ([#211](#211)) ([168783a](168783a)), closes [#209](#209) [#209](#209) [#209](#209) [#209](#209) [#209](#209)

sw-release-bot · 2026-01-25T14:27:34Z

🎉 This PR is included in version 6.46.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copilot AI review requested due to automatic review settings January 25, 2026 13:39

Copilot started reviewing on behalf of polaz January 25, 2026 13:39 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

src/logger.ts Outdated Show resolved Hide resolved

polaz added 2 commits January 25, 2026 15:44

test(logging): Add unit tests for logger helper functions

9f1dde8

- Add tests for logInfo, logWarn, logError, logDebug functions - Test JSON mode and plain mode output formats - Test nested objects and various data types handling Related to #209

fix(logging): Handle Error objects in formatDataPairs

27e122d

- Add special case for Error objects to preserve stack/message - Handle null and undefined values explicitly - Add tests for Error and undefined handling Related to #209

polaz requested a review from Copilot January 25, 2026 13:49

Copilot started reviewing on behalf of polaz January 25, 2026 13:50 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

polaz added 2 commits January 25, 2026 15:57

test(rate-limiter): Add tests for rate limit exceeded and threshold w…

dd76f05

…arning - Add test for 429 response when IP rate limit exceeded - Add test for debug log when approaching 80% threshold - Use unique IPs per test to ensure per-IP isolation Related to #209

test(ConnectionManager): Add tests for ensureIntrospected method

53b1f00

- Add test for error when called before initialization - Add test for early return when already introspected Related to #209

polaz requested a review from Copilot January 25, 2026 14:02

Copilot started reviewing on behalf of polaz January 25, 2026 14:02 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

polaz added 3 commits January 25, 2026 16:05

test(rate-limiter): Add per-IP isolation and limit exceeded tests

70d51e1

- Add test verifying separate rate limits tracked per IP address - Add test for 429 response when IP rate limit exceeded - Add test for debug log when approaching 80% threshold

test(oauth): Add tests for Dynamic Client Registration endpoint

4484f5a

- Add tests for registerHandler (public/confidential clients, validation) - Add tests for getRegisteredClient and isValidRedirectUri - Add test for error handling in registration

polaz requested a review from Copilot January 25, 2026 14:17

Copilot started reviewing on behalf of polaz January 25, 2026 14:18 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

polaz merged commit 168783a into main Jan 25, 2026
26 of 27 checks passed

polaz deleted the feat/#209-fixlogging-apply-logjson-pattern-to-all-logger-cal branch January 25, 2026 14:21

sw-release-bot bot added the released label Jan 25, 2026

sw-release-bot bot mentioned this pull request Mar 29, 2026

chore(main): release gitlab-mcp 7.0.0 #368

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(logging): Apply LOG_JSON pattern to all logger calls#211

fix(logging): Apply LOG_JSON pattern to all logger calls#211
polaz merged 8 commits intomainfrom
feat/#209-fixlogging-apply-logjson-pattern-to-all-logger-cal

polaz commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

sw-release-bot bot commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

polaz commented Jan 25, 2026

Summary

Changes

Test plan

Uh oh!

github-actions bot commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Coverage Report

Uh oh!

codecov bot commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sw-release-bot bot commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 25, 2026 •

edited

Loading

codecov bot commented Jan 25, 2026 •

edited

Loading