fix(docs): inline constants removed with dead code cleanup#158
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken documentation build caused by missing imports. After PR #156 removed dead Pages Function code including docs/functions/api/utils.ts, the BugReportWidget.vue component still referenced constants from that deleted file, breaking the Deploy Documentation workflow on main.
Changes:
- Inline
MIN_DESCRIPTION_LENGTHandCATEGORIESconstants directly inBugReportWidget.vue - Remove import statement for the deleted
utils.tsfile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in version 6.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploy Documentationworkflow onmaincaused by missing importBugReportWidget.vueimportedCATEGORIESandMIN_DESCRIPTION_LENGTHfromdocs/functions/api/utils.tswhich was deleted in feat(docs): domain migration, branding assets, dead code cleanup #156Fixes #157
Test plan
yarn docs:buildpasses locally