fix(mrs): use global API endpoints for code change proposals (#116)

polaz · web-flow · commit 891b5b1ee3bf · 2026-01-22T12:57:50.000+02:00
Change endpoints from nested project paths to global paths: - PUT /suggestions/:id/apply - PUT /suggestions/batch_apply Fixes #115
diff --git a/src/entities/mrs/registry.ts b/src/entities/mrs/registry.ts
@@ -418,22 +418,26 @@ export const mrsToolRegistry: ToolRegistry = new Map<string, EnhancedToolDefinit
 
           case "apply_suggestion": {
             // TypeScript knows: input has suggestion_id (required), commit_message (optional)
-            const { project_id, merge_request_iid, suggestion_id, commit_message } = input;
+            // Note: project_id and merge_request_iid are in schema for context but not used in API
+            // GitLab suggestions API uses global endpoint: PUT /suggestions/:id/apply
+            const { suggestion_id, commit_message } = input;
 
             const body: Record<string, unknown> = {};
             if (commit_message) {
               body.commit_message = commit_message;
             }
 
-            return gitlab.put(
-              `projects/${normalizeProjectId(project_id)}/merge_requests/${merge_request_iid}/suggestions/${suggestion_id}/apply`,
-              { body: Object.keys(body).length > 0 ? body : undefined, contentType: "json" }
-            );
+            return gitlab.put(`suggestions/${suggestion_id}/apply`, {
+              body: Object.keys(body).length > 0 ? body : undefined,
+              contentType: "json",
+            });
           }
 
           case "apply_suggestions": {
             // TypeScript knows: input has suggestion_ids (required), commit_message (optional)
-            const { project_id, merge_request_iid, suggestion_ids, commit_message } = input;
+            // Note: project_id and merge_request_iid are in schema for context but not used in API
+            // GitLab suggestions API uses global endpoint: PUT /suggestions/batch_apply
+            const { suggestion_ids, commit_message } = input;
 
             const body: Record<string, unknown> = {
               ids: suggestion_ids,
@@ -442,10 +446,7 @@ export const mrsToolRegistry: ToolRegistry = new Map<string, EnhancedToolDefinit
               body.commit_message = commit_message;
             }
 
-            return gitlab.put(
-              `projects/${normalizeProjectId(project_id)}/merge_requests/${merge_request_iid}/suggestions/batch_apply`,
-              { body, contentType: "json" }
-            );
+            return gitlab.put(`suggestions/batch_apply`, { body, contentType: "json" });
           }
 
           case "resolve": {
diff --git a/tests/unit/entities/mrs/registry.test.ts b/tests/unit/entities/mrs/registry.test.ts
@@ -1162,8 +1162,9 @@ describe("MRS Registry", () => {
             suggestion_id: 12345,
           });
 
+          // GitLab suggestions API uses global endpoint: PUT /suggestions/:id/apply
           expect(mockGitlab.put).toHaveBeenCalledWith(
-            "projects/test%2Fproject/merge_requests/42/suggestions/12345/apply",
+            "suggestions/12345/apply",
             expect.objectContaining({
               body: undefined,
               contentType: "json",
@@ -1185,8 +1186,9 @@ describe("MRS Registry", () => {
             commit_message: "Apply suggestion: fix typo",
           });
 
+          // GitLab suggestions API uses global endpoint: PUT /suggestions/:id/apply
           expect(mockGitlab.put).toHaveBeenCalledWith(
-            "projects/test%2Fproject/merge_requests/42/suggestions/12345/apply",
+            "suggestions/12345/apply",
             expect.objectContaining({
               body: { commit_message: "Apply suggestion: fix typo" },
               contentType: "json",
@@ -1209,8 +1211,9 @@ describe("MRS Registry", () => {
             suggestion_ids: [12345, 12346, 12347],
           });
 
+          // GitLab suggestions API uses global endpoint: PUT /suggestions/batch_apply
           expect(mockGitlab.put).toHaveBeenCalledWith(
-            "projects/test%2Fproject/merge_requests/42/suggestions/batch_apply",
+            "suggestions/batch_apply",
             expect.objectContaining({
               body: { ids: [12345, 12346, 12347] },
               contentType: "json",
@@ -1232,8 +1235,9 @@ describe("MRS Registry", () => {
             commit_message: "Apply code review suggestions",
           });
 
+          // GitLab suggestions API uses global endpoint: PUT /suggestions/batch_apply
           expect(mockGitlab.put).toHaveBeenCalledWith(
-            "projects/test%2Fproject/merge_requests/42/suggestions/batch_apply",
+            "suggestions/batch_apply",
             expect.objectContaining({
               body: {
                 ids: [12345, 12346],
